Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about <topic> system paramter in JointStatePublisher #1671

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Add information about <topic> system paramter in JointStatePublisher #1671

merged 1 commit into from
Aug 29, 2022

Conversation

ijnek
Copy link
Contributor

@ijnek ijnek commented Aug 28, 2022 •
edited
Loading

🦟 Bug fix

Adding in missing API docs for changes from #1076

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ijnek ijnek requested a review from mjcarroll as a code owner August 28, 2022 09:35
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Aug 28, 2022
@ijnek
Add information about <topic> system paramter
751eefd 
Adding some API docs for changes from gazebosim#1076

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@ahcorde ahcorde merged commit 85bab4c into gazebosim:ign-gazebo6 Aug 29, 2022
@ijnek ijnek deleted the patch-1 branch August 30, 2022 23:17
@ijnek
Copy link
Contributor Author

ijnek commented Aug 30, 2022

Thanks @ahcorde !

traversaro pushed a commit to traversaro/ign-gazebo that referenced this pull request Oct 19, 2022
@ijnek @traversaro
Add information about <topic> system paramter (gazebosim#1671)
df42865 
Adding some API docs for changes from gazebosim#1076

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Silvio <silvio@traversaro.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijnek @ahcorde