Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set camera clipping plane distance #1162

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

jennuine
Copy link
Contributor

@jennuine jennuine commented Nov 3, 2021

🎉 New feature

Related to gazebosim/gz-gui#308
Closes #1154

Summary

Set the user camera's near/far clipping plane distance through the View Angle plugin.

Test it

  1. ign gazebo minimal_shapes.sdf
  2. Expand View Angle plugin
  3. Enter near/far values in spin boxes

Peek 2021-11-03 14-48

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
@jennuine jennuine requested a review from scpeters November 3, 2021 21:49
@jennuine jennuine self-assigned this Nov 3, 2021
@jennuine jennuine requested a review from chapulina as a code owner November 3, 2021 21:49
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Nov 3, 2021
@jennuine jennuine requested a review from iche033 November 3, 2021 22:08
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #1162 (8df76f5) into ign-gazebo6 (35ec2a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo6    #1162   +/-   ##
============================================
  Coverage        63.72%   63.72%           
============================================
  Files              256      256           
  Lines            20116    20116           
============================================
  Hits             12819    12819           
  Misses            7297     7297           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35ec2a7...8df76f5. Read the comment docs.

@chapulina chapulina added GUI Gazebo's graphical interface (not pure Ignition GUI) rendering Involves Ignition Rendering labels Nov 3, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chapulina chapulina merged commit 4e879a8 into ign-gazebo6 Nov 4, 2021
@chapulina chapulina deleted the jennuine/camera_clip branch November 4, 2021 00:00
srmainwaring pushed a commit to srmainwaring/gz-sim that referenced this pull request Nov 11, 2021
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden GUI Gazebo's graphical interface (not pure Ignition GUI) rendering Involves Ignition Rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase/Decrease viewport clipping distance
2 participants