minimal_scene.sdf example: add camera_clip params #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds example camera_clip parameters to the MinimalScene plugin in the example world file minimal_scene.sdf These parameters were added in gazebosim/gz-gui#309 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
jennuine
reviewed
Nov 5, 2021
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1166 +/- ##
============================================
Coverage 62.18% 62.18%
============================================
Files 256 256
Lines 20355 20355
============================================
Hits 12657 12657
Misses 7698 7698 Continue to review full report at Codecov.
|
I tested with the current release of ign-gazebo6 and ign-gui6, and it didn't give any error messages. I think the parameters are just ignored, so I would be fine with merging now, but can also wait if needed |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
I noticed |
jennuine
approved these changes
Nov 5, 2021
WilliamLewww
pushed a commit
to WilliamLewww/ign-gazebo
that referenced
this pull request
Dec 7, 2021
This adds example camera_clip parameters to the MinimalScene plugin in the example world file minimal_scene.sdf These parameters were added in gazebosim/gz-gui#309 Also increase timeout for examples build test Signed-off-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Small follow-up to gazebosim/gz-gui#309 and #1162
Summary
This adds example
camera_clipparameters to theMinimalSceneplugin in the example world fileminimal_scene.sdf. These parameters were added in gazebosim/gz-gui#309.Test it
If you build against
ign-gui6from souce, then when you openminimal_scene.sdfand expand the View Angle widget, you should see the values 0.25 and 25000 in the "Camera's clipping plane distance" section.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge