Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.1.0 #485

Merged
merged 1 commit into from
Dec 14, 2020
Merged

4.1.0 #485

merged 1 commit into from
Dec 14, 2020

Conversation

adlarkin
Copy link
Contributor

Prepare for 4.1.0 release.

The motivation for this release is to add the wheel slip plugin to Dome for https://github.com/osrf/subt/tree/dome.

Comparison to 4.0.0: ignition-gazebo4_4.0.0...ign-gazebo4

Signed-off-by: Ashton Larkin ashton@openrobotics.org

@adlarkin adlarkin requested a review from nkoenig December 12, 2020 00:59
@adlarkin adlarkin requested a review from chapulina as a code owner December 12, 2020 00:59
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Dec 12, 2020
adlarkin
adlarkin commented Dec 12, 2020
View reviewed changes
Copy link
Contributor Author

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions I have for any reviewers.

Changelog.md Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
@adlarkin
Copy link
Contributor Author

It looks like #229 was merged into ign-gazebo4 shortly after making this PR. I'm waiting to update this branch to include #229 because it looks like #229 may not have been merged with the right strategy (it seems like a regular merge was done instead of a squash merge). I posted a comment in #229 asking about this and am waiting for a response: #229 (comment)

@nkoenig
Copy link
Contributor

nkoenig commented Dec 14, 2020 •
edited
Loading

It looks like #229 was merged into ign-gazebo4 shortly after making this PR. I'm waiting to update this branch to include #229 because it looks like #229 may not have been merged with the right strategy (it seems like a regular merge was done instead of a squash merge). I posted a comment in #229 asking about this and am waiting for a response: #229 (comment)

We can fix the git history independent of a release. It's okay to move forward with the release. Can you add in the changelog entry for #229?

@adlarkin
Copy link
Contributor Author

We can fix the git history independent of a release. It's okay to move forward with the release. Can you add in the changelog entry for #229?

Added #229 to the changelog in 1e80914. Everything should be up to date with ign-gazebo4 now.

chapulina
chapulina approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adlarkin !

#229

We should try to always squash-merge non-porting PRs, but when those slip in without squashing, we shouldn't go back and rewrite history in a release branch (in this case, ign-gazebo4), because that could be disruptive to everyone's workflows and open PRs. So we can proceed as it is.

Before triggering the release, please be sure to open a PR against https://github.com/ignition-release/ign-gazebo4-release bumping the minimum required versions for dependencies. If you look in the comparison link you posted, we need to bump ign-physics to 3.1.0 and ign-rendering to 4.1.0.

@adlarkin
Copy link
Contributor Author

Before triggering the release, please be sure to open a PR against https://github.com/ignition-release/ign-gazebo4-release bumping the minimum required versions for dependencies. If you look in the comparison link you posted, we need to bump ign-physics to 3.1.0 and ign-rendering to 4.1.0.

I saw this commit that indicates the dependency on ign-rendering4.1.0, but can't seem to find the ign-physics3.1.0 dependency. How did you find that dependency update? (I want to make sure I'm aware for future releases)

@adlarkin adlarkin mentioned this pull request Dec 14, 2020
Merged
@adlarkin
Copy link
Contributor Author

It looks like a few checks failed (GitHub actions and Jenkins Ubuntu CI) - I'm double checking the failures to make sure nothing is problematic for this release.

@adlarkin
Copy link
Contributor Author

It looks like a few checks failed (GitHub actions and Jenkins Ubuntu CI) - I'm double checking the failures to make sure nothing is problematic for this release.

There were two tests that failed, and the failures for GitHub actions and Jenkins appear to be the same. The failures both seem to be related to fuel model paths, and it looks like these failures were already occurring for several builds in Jenkins. Here are the Jenkins failures: https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/4766/testReport/

This seems like an odd failure to me, and the fact that fuel model tests are failing may be problematic for SubT. Should we try to resolve these test failures before moving forward with this release?

@nkoenig
Copy link
Contributor

nkoenig commented Dec 14, 2020

This seems like an odd failure to me, and the fact that fuel model tests are failing may be problematic for SubT. Should we try to resolve these test failures before moving forward with this release?

No, we can resolve test failures in a separate PR. Please go ahead with the release.

@adlarkin
4.1.0 (#485)
65b4b78 
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@chapulina
Copy link
Contributor

The failures both seem to be related to fuel model paths

They should be fixed when #480 is forward-ported.

@adlarkin adlarkin merged commit 65b4b78 into ign-gazebo4 Dec 14, 2020
@adlarkin adlarkin deleted the adlarkin/4.1.0 branch December 14, 2020 21:20
Lobotuerk added a commit to Lobotuerk/ign-gazebo that referenced this pull request Jan 11, 2021
@Lobotuerk @mcres
@chapulina @mabelzhang @azeey @mjcarroll @adlarkin @iche033 @ivanpauno @ahcorde @nkoenig @doisyg @gonzodepedro @scpeters @j-rivero @acxz @caguero
Fork update (#1)
9378df3 
* Initial commit

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Added plugin files

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Initial .sdf file

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Pipeline for getting sensor contacts

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Added visualization of postion and forces

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Added plugin for Transform Control

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Added initial interpolation

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Code check

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Update info after specified milliseconds

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Set marker lifetime for better performance

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Added Depth Camera

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Added callback and unpacking to Depth Camera messages

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Compute and visualize normal forces

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* PR Feedback 1

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Update sdf example to a more realistic environment

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Allow moving Depth Camera from model origin

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Make markers dimensions available as parameters

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Visualize sensor as a marker instead of <visual> and filter out normal forces outside sensor

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* PR Feedback 2

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* PR Feedback 3

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* Minor fixes for sdf, sensor marker and profiler

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* PR Feedback 4

Signed-off-by: Martiño Crespo <marticres@gmail.com>

* fix mac warning

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* Helper function to set component data (gazebosim#436)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Remove unneeded if statement (gazebosim#432)

Signed-off-by: John Shepherd <john@openrobotics.org>

* Fixes flaky RecordAndPlayback test in INTEGRATION_log_system (gazebosim#463)

The flakiness comes from two sources:
1. Poses recorded by the LogRecorder are published by the
   SceneBroadcaster system throttled at 60 Hz. The throttle mechanism
   uses real-time instead of sim-time which causes a variance in the
   number of recorded poses from run to run. However, the expected number of
   recorded poses was calculated with the assumption that the simulation
   would run with a 1.0 RTF. If the CPU load is high, there could be a
   mismatch between the expected and the actual number of recorded
   poses, which causes the test to fail.
   This can be checked by running the test with
`cpulimit -l 20 -f  bin/INTEGRATION_log_system  -- --gtest_filter="*RecordAndPlayback"`

2. An attempt is made to match up played back poses with the closest
   timestamp in the recorded file. These poses are again published by
   the SceneBroadcaster, so they are subject to the same kind of timing
   issues as the recorded poses.

The solution in this patch for the first issue is to determine the
expected number of recorded poses by counting them in a separate system
that mimics the throttling mechanism of ign-transport. For the second
issue, a testing system is added to the playback server bypassing the
SceSceneBroadcaster altogether.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* Make PeerTracker test more robust (gazebosim#452)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Michael Carroll <michael@openrobotics.org>

* Clarify how sim time is interpreted in a System's step (gazebosim#467)

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>

* 3 ➡️  4: fixes for gazebosim#463 (gazebosim#469)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Link link tutrial (gazebosim#472)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Switch to async state service request (gazebosim#461)

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* Use a std::promise/std::future to avoid busy waiting the step ack messages in NetworkManagerPrimary (gazebosim#470)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>

* Fix tests that use Fuel paths with uppercase letters (gazebosim#480)

As of gazebosim/gz-fuel-tools#130, fuel paths use all lowercase letters. This fixes some tests that had uppercase letters.
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* 4.1.0 (gazebosim#485)

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>

* Update key event handling (gazebosim#466)

Signed-off-by: John Shepherd <john@openrobotics.org>

* Fix slot in Plotting plugin (gazebosim#490)

Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>

* Tape Measure Plugin (gazebosim#456)

Signed-off-by: John Shepherd <john@openrobotics.org>

* Satisfy make codecheck (gazebosim#491)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Move deselect and preview termination to render thread (gazebosim#493)

Signed-off-by: John Shepherd <john@openrobotics.org>

* Fix codecheck (gazebosim#499)

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>

* Logical Audio Sensor Plugin (gazebosim#401)

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>

* Codecheck - initialize primitive in LogicalAudio component (gazebosim#502)

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>

* 3 to 4: fix codecheck for ign-gazebo4

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>

* 3 to 4: resolve codecheck warnings

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>

* add frame_id and child_frame_id attribute support for DiffDrive (gazebosim#361)

Add configuration of the odom frame_id and child_frame_id fields from sdf attributes <frame_id> and <child_frame_id>

Signed-off-by: Guillaume <guillaume.doisy@wyca.fr>
Signed-off-by: Guillaume Doisy <guillaume.doisy@wyca.fr>

* Require ign-gui 4.1.0 (gazebosim#505)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Fix shadow artifacts by disabling double sided rendering (gazebosim#446)

* read double sided sdf param

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* update migration

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* Make the tunnels example world more interesting (gazebosim#462)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* add double sided msg to sdf conversion

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>

* Add ability to record video based on sim time (gazebosim#414)

* add ability to record video from gui camera using sim time

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* add msg

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* use QueryBoolText

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>

* Add lockstep mode to video recording (gazebosim#419)

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>

* Kinetic energy monitor plugin (gazebosim#492)

Signed-off-by: Gonzalo de Pedro <gonzalo@depedro.com.ar>
Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>

* Disable right click menu when using measuring tool (gazebosim#458)

Signed-off-by: John Shepherd <john@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>

* Bump to 3.6.0 (gazebosim#524)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Don't make docs on macOS (gazebosim#528)

add comment about doxygen bug

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>

* Updates to ardupilot migration tutorial (gazebosim#525)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Update gtest to 1.10.0 for Windows compilation (ign-gazebo3) (gazebosim#506)

* Compile new gtest with c++11
* Use INSTANTIATE_TEST_SUITE_P instead of deprecated -INSTANTIATE_TEST_CASE_P

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

* Apply suggestions from code review

Signed-off-by: Michael Carroll <michael@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>

* change nullptr to a int ptr for qt 5.15.2 bug (gazebosim#527)

See: https://bugreports.qt.io/browse/QTBUG-89114
Signed-off-by: acxz <17132214+acxz@users.noreply.github.com>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Generate valid topics everywhere (support names with spaces) (gazebosim#522)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* One more tutorial version bump

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Fix bad merge

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* change nullptr to a int ptr for qt 5.15.2 bug (gazebosim#527)

See: https://bugreports.qt.io/browse/QTBUG-89114
Signed-off-by: acxz <17132214+acxz@users.noreply.github.com>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Generate valid topics everywhere (support names with spaces) (gazebosim#522)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Change deprecated test case->suite

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* 3 ➡️ 4 (gazebosim#533)

* Clarify how sim time is interpreted in a System's step (gazebosim#467)
* add frame_id and child_frame_id attribute support for DiffDrive (gazebosim#361)
* Add ability to record video based on sim time (gazebosim#414)
* add ability to record video from gui camera using sim time
* add msg
* use QueryBoolText
* Add lockstep mode to video recording (gazebosim#419)
* Disable right click menu when using measuring tool (gazebosim#458)
* Bump to 3.6.0 (gazebosim#524)
* Don't make docs on macOS (gazebosim#528)
* Updates to ardupilot migration tutorial (gazebosim#525)
* Update gtest to 1.10.0 for Windows compilation (ign-gazebo3) (gazebosim#506)
* Compile new gtest with c++11
* Use INSTANTIATE_TEST_SUITE_P instead of deprecated -INSTANTIATE_TEST_CASE_P
* Apply suggestions from code review
* One more tutorial version bump
* Fix bad merge
* change nullptr to a int ptr for qt 5.15.2 bug (gazebosim#527)
* Generate valid topics everywhere (support names with spaces) (gazebosim#522)
* Change deprecated test case->suite

Co-authored-by: Ashton Larkin <ashton@openrobotics.org>
Co-authored-by: G.Doisy <doisyg@users.noreply.github.com>
Co-authored-by: Ian Chen <ichen@osrfoundation.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: John Shepherd <john@openrobotics.org>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Co-authored-by: Akash Patel <17132214+acxz@users.noreply.github.com>

* Add support for topic statistics on breadcrumb deployments (gazebosim#532)

* Add support for topic statistics on breadcrumb deployments

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Require version 9.1 of ignition transport

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Move to after mutex

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Carlos Agüero <caguero@osrfoundation.org>

Co-authored-by: Martiño Crespo <marticres@gmail.com>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: John Shepherd <john@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Ashton Larkin <ashton@openrobotics.org>
Co-authored-by: Ian Chen <ichen@osrfoundation.org>
Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: G.Doisy <doisyg@users.noreply.github.com>
Co-authored-by: Gonzo <42421541+gonzodepedro@users.noreply.github.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Co-authored-by: Akash Patel <17132214+acxz@users.noreply.github.com>
Co-authored-by: Carlos Agüero <caguero@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig nkoenig approved these changes

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adlarkin @nkoenig @chapulina