Added light tutorial and example #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
added
the
needs upstream release
chapulina
suggested changes
Dec 29, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
I will rewrite some parts and maybe I will create another tutorial to add models |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
iche033
reviewed
Jan 14, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
chapulina
removed
the
needs upstream release
Signed-off-by: Louise Poubel <louise@openrobotics.org>
|
I retargeted this PR at #482 because the example needs a component introduced there. This should fix the test on this branch, and also allow testing the code. |
|
Thank you @chapulina, then we can merge this in the other PR. @iche033 friendly ping |
iche033
reviewed
Feb 2, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
iche033
approved these changes
Feb 2, 2021
ahcorde
added a commit
that referenced
this pull request
Feb 17, 2021
* Added light tutorial and example Signed-off-by: ahcorde <ahcorde@gmail.com> * Added some feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Split tutorial in two Signed-off-by: ahcorde <ahcorde@gmail.com> * remove ids from tutorial Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * update tutorial Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Feb 17, 2021
* Added light tutorial and example Signed-off-by: ahcorde <ahcorde@gmail.com> * Added some feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Split tutorial in two Signed-off-by: ahcorde <ahcorde@gmail.com> * remove ids from tutorial Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * update tutorial Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added light tutorial and example
Related to:
Signed-off-by: ahcorde ahcorde@gmail.com