-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model creation tutorial using services #530
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I just have some minor suggestions.
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some tweaks. Thanks for the tutorial!
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #530 +/- ##
===============================================
+ Coverage 77.29% 77.31% +0.02%
===============================================
Files 208 215 +7
Lines 11198 12029 +831
===============================================
+ Hits 8655 9300 +645
- Misses 2543 2729 +186
Continue to review full report at Codecov.
|
@chapulina Thank you for the fixes! Merging! |
* Model creation tutorial using services Signed-off-by: ahcorde <ahcorde@gmail.com> * Updated tutorial Signed-off-by: ahcorde <ahcorde@gmail.com> * Tweaks to tutorial and example Signed-off-by: Louise Poubel <louise@openrobotics.org> * Move files Signed-off-by: Louise Poubel <louise@openrobotics.org> * example only needs ign-transport Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
I splitted this tutorial #515 in two parts as suggested by @chapulina
Include:
Signed-off-by: ahcorde ahcorde@gmail.com