Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model creation tutorial using services #530

Merged
merged 8 commits into from
Feb 1, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jan 5, 2021

I splitted this tutorial #515 in two parts as suggested by @chapulina

Include:

  • Tutorial
  • Example

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the documentation Improvements or additions to documentation label Jan 5, 2021
@ahcorde ahcorde requested a review from chapulina January 5, 2021 13:17
@ahcorde ahcorde self-assigned this Jan 5, 2021
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jan 5, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just have some minor suggestions.

examples/standalone/model_creation/model_creation.cc Outdated Show resolved Hide resolved
examples/standalone/model_creation/model_creation.cc Outdated Show resolved Hide resolved
tutorials/model_creation.md Outdated Show resolved Hide resolved
tutorials/model_creation.md Outdated Show resolved Hide resolved
tutorials/model_creation.md Outdated Show resolved Hide resolved
tutorials/model_creation.md Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina January 6, 2021 09:07
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some tweaks. Thanks for the tutorial!

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #530 (8bfc1a6) into ign-gazebo4 (2a25fc7) will increase coverage by 0.02%.
The diff coverage is 80.44%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #530      +/-   ##
===============================================
+ Coverage        77.29%   77.31%   +0.02%     
===============================================
  Files              208      215       +7     
  Lines            11198    12029     +831     
===============================================
+ Hits              8655     9300     +645     
- Misses            2543     2729     +186     
Impacted Files Coverage Δ
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/System.hh 100.00% <ø> (ø)
...e/ignition/gazebo/detail/EntityComponentManager.hh 95.00% <ø> (ø)
include/ignition/gazebo/gui/GuiRunner.hh 100.00% <ø> (ø)
src/SimulationRunner.hh 100.00% <ø> (ø)
src/gui/plugins/entity_tree/EntityTree.hh 100.00% <ø> (ø)
.../gui/plugins/transform_control/TransformControl.hh 100.00% <ø> (ø)
src/ign.cc 72.18% <ø> (ø)
src/systems/breadcrumbs/Breadcrumbs.hh 100.00% <ø> (ø)
src/systems/buoyancy/Buoyancy.cc 75.28% <ø> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a7329...cf00c57. Read the comment docs.

@ahcorde
Copy link
Contributor Author

ahcorde commented Feb 1, 2021

@chapulina Thank you for the fixes! Merging!

@ahcorde ahcorde merged commit 4c87e1d into ign-gazebo4 Feb 1, 2021
@ahcorde ahcorde deleted the ahcorde/tutorial/model_creation branch February 1, 2021 17:28
chapulina added a commit that referenced this pull request Jul 23, 2021
* Model creation tutorial using services

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Updated tutorial

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Tweaks to tutorial and example

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Move files

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* example only needs ign-transport

Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants