Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joint controller GUI test #697

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

The JoingPositionController_TEST was broken when #534 was forward-ported in #689.

I think this fix is also reasonable for ign-gazebo3, but for some timing issue, the test doesn't seem to be failing there. So I'm fixing it here and we can backport if needed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added bug Something isn't working GUI Gazebo's graphical interface (not pure Ignition GUI) tests Broken or missing tests / testing infra labels Mar 19, 2021
@chapulina chapulina requested a review from mjcarroll March 19, 2021 01:30
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #697 (99698a6) into ign-gazebo4 (302f5ed) will decrease coverage by 11.85%.
The diff coverage is 68.55%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo4     #697       +/-   ##
================================================
- Coverage        77.37%   65.51%   -11.86%     
================================================
  Files              217      237       +20     
  Lines            12217    17197     +4980     
================================================
+ Hits              9453    11267     +1814     
- Misses            2764     5930     +3166     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/rendering/SceneManager.hh 100.00% <ø> (ø)
src/Conversions.cc 82.03% <ø> (+0.13%) ⬆️
.../plugins/component_inspector/ComponentInspector.cc 7.29% <0.00%> (-1.32%) ⬇️
.../plugins/component_inspector/ComponentInspector.hh 28.57% <ø> (ø)
src/network/PeerTracker.hh 100.00% <ø> (ø)
src/systems/apply_joint_force/ApplyJointForce.hh 100.00% <ø> (ø)
src/systems/breadcrumbs/Breadcrumbs.hh 100.00% <ø> (ø)
src/systems/buoyancy/Buoyancy.hh 100.00% <ø> (ø)
src/systems/contact/Contact.hh 100.00% <ø> (ø)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a5ece...99698a6. Read the comment docs.

@mjcarroll mjcarroll merged commit 778ff85 into ign-gazebo4 Mar 19, 2021
@mjcarroll mjcarroll deleted the chapulina/4/joint_test branch March 19, 2021 13:02
@chapulina chapulina mentioned this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🔮 dome Ignition Dome GUI Gazebo's graphical interface (not pure Ignition GUI) tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants