4 ➡️ 5

[chapulina]

➡️ Forward port

Port ign-gazebo4 to main

Branch comparison: main...ign-gazebo4

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

[adlarkin]

@chapulina, I went ahead and updated this PR with the latest changes from the main branch (c526c9d). @mjcarroll took a look, and everything seems to be okay. I'll wait to see what results we get from CI.

[chapulina]

The JointPositionController_TEST failed again, and I don't see the changes from #697 on this branch, so I'll give the merge another try

[chapulina]

🤞

[codecov]

Codecov Report

Merging #695 (84ae007) into main (ddcf64f) will increase coverage by 0.45%.
The diff coverage is 77.14%.

@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
+ Coverage   64.91%   65.36%   +0.45%     
==========================================
  Files         235      240       +5     
  Lines       16958    17514     +556     
==========================================
+ Hits        11008    11448     +440     
- Misses       5950     6066     +116     

Impacted Files	Coverage Δ
src/rendering/RenderUtil.cc	42.46% <0.00%> (-0.19%)	⬇️
src/systems/velocity_control/VelocityControl.hh	100.00% <ø> (ø)
src/gui/plugins/scene3d/Scene3D.cc	9.36% <12.50%> (-0.58%)	⬇️
src/gui/plugins/entity_tree/EntityTree.cc	13.11% <50.00%> (-0.63%)	⬇️
...int_position_controller/JointPositionController.cc	60.57% <60.57%> (ø)
src/systems/ackermann_steering/SpeedLimiter.cc	85.71% <85.71%> (ø)
...rc/systems/ackermann_steering/AckermannSteering.cc	86.79% <86.79%> (ø)
src/systems/physics/Physics.cc	69.03% <86.95%> (+0.22%)	⬆️
...int_position_controller/JointPositionController.hh	100.00% <100.00%> (ø)
...rc/systems/ackermann_steering/AckermannSteering.hh	100.00% <100.00%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddcf64f...84ae007. Read the comment docs.

[chapulina]

Ahhhh Windows, let me fix it

[chapulina]

Pushed an attempt at fixing Windows linker errors for the GUI test

[chapulina]

Latest push disables the GUI plugin tests on Windows for now

[adlarkin]

Latest push disables the GUI plugin tests on Windows for now

Should we create an issue so that we can re-visit this later?

[chapulina]

Should we create an issue so that we can re-visit this later?

There are lots of disabled and failing tests on Windows, so I think at this point we don't need to track them individually yet.

[chapulina]

Ok! Windows is building. The only suspicious test failure is a timeout for INTEGRATION_examples_build, which I don't think I've seen before. But it looks to me that it could be due to a slow CI machine. Merging!

81: [ 50%] Building CXX object CMakeFiles/joy_to_twist.dir/joy_to_twist.cc.o
 81/174 Test  #81: INTEGRATION_examples_build .............................***Timeout 240.01 sec