Fix WindEffects Plugin bug, not configuring new links

[Blast545]

🦟 Bug fix

Fixes #843

Summary

Fixes tagged issue. I'm not sure how to test this bug fix, can I get some advice about how to this fix? I imagine the test would be something like:

1. Create server
2. Add links with wind
3. Run sim iteration
4. Check if wind was added
5. Add more links with wind
6. Check if wind was added to the new ones.

Let me know your thoughts.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Signed-off-by: Jorge Perez jjperez@ekumenlabs.com

[azeey]

This looks good! For testing, I recommend using the user-commands system to spawn a model as done in this example: https://github.com/ignitionrobotics/ign-gazebo/blob/80379fb4515c246a6b0bc2ee078755eb83230655/test/integration/touch_plugin.cc#L233

[Blast545]

@azeey I followed your advice with the test, let me know what you think :)

[azeey]

I just realized this is targeting Edifice. In general we try to create PRs targetting the earliest supported version and forward port once it gets merged. If there is no specific reason for targetting Edifice, would you mind changing it to citadel (ign-gazebo3)?

@azeey I followed your advice with the test, let me know what you think :)

The test looks great! Thanks.

[chapulina]

@Blast545 , can this be moved to "In review"? Also I noticed you retargeted to ign-gazebo3 then back, are you still working on retargeting?

[Blast545]

@chapulina Yes! I'm re-targeting it. I thought using the web GUI was enough, and when I saw the conflicts I realized I'll have to do it manually 😆 Moved to in-review.

[codecov]

Codecov Report

Merging #844 (93c93f8) into ign-gazebo3 (5a3b1b8) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

❗ Current head 93c93f8 differs from pull request most recent head fa0dfa5. Consider uploading reports for the commit fa0dfa5 to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo3     #844      +/-   ##
===============================================
- Coverage        77.98%   77.97%   -0.02%     
===============================================
  Files              216      216              
  Lines            12131    12130       -1     
===============================================
- Hits              9460     9458       -2     
- Misses            2671     2672       +1     

Impacted Files	Coverage Δ
src/systems/wind_effects/WindEffects.cc	79.55% <87.50%> (-0.67%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3b1b8...fa0dfa5. Read the comment docs.

[Blast545]

@azeey CI all green (except codecov) PTAL, I think is ready to merge :D

[azeey]

Thanks!