Updated Shapes plugin to work with MinimalScene #979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
8 tasks
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
chapulina
reviewed
Aug 19, 2021
| namespace ignition::gazebo | ||
| { | ||
| class ShapesPrivate | ||
| { | ||
| /// \brief Handle shapes | ||
| public: void handleShapes(); |
There was a problem hiding this comment.
The name of this method isn't very descriptive. How about OnRender, since it seems to handle everything that happens in the render thread?
8 tasks
|
superseded by #983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
Summary
It allows to create shapes inside the minimalScene. It still not working because of a racecondition when running in the same process
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge