Merge sdf9 ➡️ sdf12 #1286
Merged
Merge sdf9 ➡️ sdf12 #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting from URDF to SDFormat, some links without an <inertial> block or a small mass may be dropped with only debug messages in a log file, which are easily missed. This makes the following changes: * When a massless link in the middle of a kinematic chain is successfully merged to its parent by fixed joint reduction, fix bug that was dropping the massless link's child links and joints. * Print no warnings or debug messages when a massless link is successfully merged to a parent by fixed joint reduction. * Promote debug messages to warnings / errors when links are dropped to improve visibility. Improve message clarity and suggest fixes to the user. * Change massless threshold test to `> 0` instead of being within a 1e-6 tolerance of 0. * Add unit and integration tests. Related to gazebosim#199 and gazebosim#1007. (cherry picked from commit 6ffe669) Signed-off-by: Aaron Chong <aaronchongth@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
|
I can't see any |
Codecov Report
@@ Coverage Diff @@
## sdf12 #1286 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 79 79
Lines 13126 13126
=======================================
Hits 12095 12095
Misses 1031 1031 |
ahcorde
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
sdf9➡️sdf12Branch comparison: sdf12...sdf9
Note: #1238 was backported to sdf9 in #1258, so there are no changes in this PR.
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)