updated loading //material colors #519
Conversation
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## master #519 +/- ##
==========================================
+ Coverage 87.97% 88.01% +0.04%
==========================================
Files 66 66
Lines 9546 9579 +33
==========================================
+ Hits 8398 8431 +33
Misses 1148 1148
Continue to review full report at Codecov.
|
src/Material_TEST.cc
Outdated
|
|
||
| sdf::Material material; | ||
| sdf::Errors errors = material.Load(elem); | ||
| PrintErrors(errors); |
There was a problem hiding this comment.
tip: You should be able to do std::cout << errors << std::endl;
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
When working on the integration test I realized that |
src/Param.cc
Outdated
| c = std::stof(token); | ||
| colors.push_back(c); | ||
| } | ||
| catch(const std::exception &/*e*/) |
There was a problem hiding this comment.
Can the caught exception be more specific like the ones in ValueFromString
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
🦟 Bug fix
Fixes #193
Summary
This fix parses
//materialcolor components (i.e., ambient, diffuse, specular, emissive) from a SDFormat file inMaterial::Loadby checking that values are eitherr,g,borr,g,b,a(expecting 3 or 4 values) and that each value is between [0,1]. If the checks do not pass, the default color0,0,0,1is used.Checklist
sh tools/code_check.sh)test coverage)
another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge