Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Edits do not persist after page load #496

Closed
d47853 opened this issue May 18, 2018 · 0 comments · Fixed by #812
Closed

Edits do not persist after page load #496

d47853 opened this issue May 18, 2018 · 0 comments · Fixed by #812

Comments

@d47853
Copy link
Member

d47853 commented May 18, 2018

Edits (such as deletion of nodes/edges or a string filter) are not persisted after a page change. On the loading of the graph page, the graph is reset meaning we lose all the edits a user has made. This can be very frustrating as a user has to repeat their work all over again

@p013570 p013570 added this to the Backlog milestone May 22, 2018
@d47853 d47853 modified the milestones: Backlog, v1.8.0 Oct 1, 2018
@d47853 d47853 added the blocked label Nov 1, 2018
@d47853 d47853 modified the milestones: v1.8.0, v1.9.0 Jan 7, 2019
@d47853 d47853 modified the milestones: v1.9.0, Backlog Mar 29, 2019
@p013570 p013570 self-assigned this Jan 8, 2020
@n3101 n3101 modified the milestones: Backlog, v2_backlog Aug 25, 2021
@n3101 n3101 removed the p:normal label Feb 15, 2022
@t92549 t92549 linked a pull request Jul 14, 2022 that will close this issue
t92549 added a commit that referenced this issue Jul 14, 2022
t92549 added a commit that referenced this issue Jul 14, 2022
* Graph layout is now saved when navigate away from page

* Fixed issue with old graph results still showing after clear

* Updating removed elements to use concat

* Updating to use forEach

Updating removePreviouslyRemovedElements to use forEach

* Updated syntax error

* Altered foreach syntax due to jasmine errors

* gh-496: Fix bug with concat

Co-authored-by: t11947 <53758970+t11947@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
@t92549 t92549 modified the milestones: v2_backlog, v1.23.0 Jul 14, 2022
@t92549 t92549 removed the in-review label Jul 14, 2022
t92549 added a commit that referenced this issue Jul 14, 2022
* Graph layout is now saved when navigate away from page

* Fixed issue with old graph results still showing after clear

* Updating removed elements to use concat

* Updating to use forEach

Updating removePreviouslyRemovedElements to use forEach

* Updated syntax error

* Altered foreach syntax due to jasmine errors

* gh-496: Fix bug with concat

Co-authored-by: t11947 <53758970+t11947@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>
t92549 added a commit that referenced this issue Jul 15, 2022
* Graph layout is now saved when navigate away from page

* Fixed issue with old graph results still showing after clear

* Updating removed elements to use concat

* Updating to use forEach

Updating removePreviouslyRemovedElements to use forEach

* Updated syntax error

* Altered foreach syntax due to jasmine errors

* gh-496: Fix bug with concat

Co-authored-by: t11947 <53758970+t11947@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>

Co-authored-by: p013570 <p013570@users.noreply.github.com>
Co-authored-by: t11947 <53758970+t11947@users.noreply.github.com>
t92549 added a commit that referenced this issue May 12, 2023
* Revert "gh-951: Add deprecation note to readme (#952)" (#983)

This reverts commit 94a4d38.

* gh-984: Change usage of log4j to slf4j (#985)

* gh-984: Change usage of log4j to slf4j

* gh-984: Checkstyle

* Updated Gaffer version to 1.22.0 (#990)

* Updated Gaffer version to 1.22.0

* Gh-986: Migrate log4j to reload4j (#992)

* gh-984: Change usage of log4j to slf4j

* gh-984: Checkstyle

* Exclude Log4j dependencies

Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>

* gh-975: Fix gafferpy alpha 1 (#994)

Co-authored-by: Gaffer <github-actions@github.com>
Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>

* prepare release gaffer-tools-1.22.0

* prepare for next development iteration

* Update links to point to v1docs (#999)

* Graph layout is now saved when navigate away from page (#812)

* Graph layout is now saved when navigate away from page

* Fixed issue with old graph results still showing after clear

* Updating removed elements to use concat

* Updating to use forEach

Updating removePreviouslyRemovedElements to use forEach

* Updated syntax error

* Altered foreach syntax due to jasmine errors

* gh-496: Fix bug with concat

Co-authored-by: t11947 <53758970+t11947@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>

* Add Deprecation message to UI README (#1061)

* Updated Gaffer version to 1.23.0 (#1064)

* Updated Gaffer version to 1.23.0

* CommonConstants replaced

* Fixed js deps

* Fixed js deps again

* Original package.json

---------

Co-authored-by: Gaffer <github-actions@github.com>

* prepare release gaffer-tools-1.23.0

* prepare for next development iteration

---------

Co-authored-by: Gaffer <github-actions@github.com>
Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>
Co-authored-by: p013570 <p013570@users.noreply.github.com>
Co-authored-by: t11947 <53758970+t11947@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants