Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

gh-984: Change usage of log4j to slf4j #985

Merged
merged 2 commits into from
Mar 25, 2022
Merged

gh-984: Change usage of log4j to slf4j #985

merged 2 commits into from
Mar 25, 2022

Conversation

t92549
Copy link
Contributor

@t92549 t92549 commented Mar 24, 2022

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@684a765). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #985   +/-   ##
==========================================
  Coverage           ?   50.50%           
  Complexity         ?      125           
==========================================
  Files              ?       42           
  Lines              ?     1596           
  Branches           ?      130           
==========================================
  Hits               ?      806           
  Misses             ?      736           
  Partials           ?       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684a765...f35aa54. Read the comment docs.

Copy link
Member

@GCHQDeveloper314 GCHQDeveloper314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you also made an improvement by combining some bits into one call, good stuff.

@t92549
Copy link
Contributor Author

t92549 commented Mar 25, 2022

I see you also made an improvement by combining some bits into one call, good stuff.

They were actually required because slf4j logger doesn't let you just log an Object. But yes I am glad it got flagged as the usage is nicer now.

@t92549 t92549 merged commit d6beb42 into develop Mar 25, 2022
@t92549 t92549 deleted the gh-984-use-slf4j branch March 25, 2022 10:36
t92549 added a commit that referenced this pull request Mar 25, 2022
* gh-984: Change usage of log4j to slf4j

* gh-984: Checkstyle
t92549 added a commit that referenced this pull request Mar 25, 2022
* gh-984: Change usage of log4j to slf4j

* gh-984: Checkstyle
t92549 added a commit that referenced this pull request May 12, 2023
* Revert "gh-951: Add deprecation note to readme (#952)" (#983)

This reverts commit 94a4d38.

* gh-984: Change usage of log4j to slf4j (#985)

* gh-984: Change usage of log4j to slf4j

* gh-984: Checkstyle

* Updated Gaffer version to 1.22.0 (#990)

* Updated Gaffer version to 1.22.0

* Gh-986: Migrate log4j to reload4j (#992)

* gh-984: Change usage of log4j to slf4j

* gh-984: Checkstyle

* Exclude Log4j dependencies

Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>

* gh-975: Fix gafferpy alpha 1 (#994)

Co-authored-by: Gaffer <github-actions@github.com>
Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>

* prepare release gaffer-tools-1.22.0

* prepare for next development iteration

* Update links to point to v1docs (#999)

* Graph layout is now saved when navigate away from page (#812)

* Graph layout is now saved when navigate away from page

* Fixed issue with old graph results still showing after clear

* Updating removed elements to use concat

* Updating to use forEach

Updating removePreviouslyRemovedElements to use forEach

* Updated syntax error

* Altered foreach syntax due to jasmine errors

* gh-496: Fix bug with concat

Co-authored-by: t11947 <53758970+t11947@users.noreply.github.com>
Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com>

* Add Deprecation message to UI README (#1061)

* Updated Gaffer version to 1.23.0 (#1064)

* Updated Gaffer version to 1.23.0

* CommonConstants replaced

* Fixed js deps

* Fixed js deps again

* Original package.json

---------

Co-authored-by: Gaffer <github-actions@github.com>

* prepare release gaffer-tools-1.23.0

* prepare for next development iteration

---------

Co-authored-by: Gaffer <github-actions@github.com>
Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com>
Co-authored-by: p013570 <p013570@users.noreply.github.com>
Co-authored-by: t11947 <53758970+t11947@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace direct usages of log4j with slf4j
3 participants