Undeprecates gafferpy #983
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #983 +/- ##
==========================================
Coverage ? 50.34%
Complexity ? 125
==========================================
Files ? 42
Lines ? 1601
Branches ? 130
==========================================
Hits ? 806
Misses ? 741
Partials ? 54 Continue to review full report at Codecov.
|
| # Deprecated | ||
| # README | ||
|
|
||
| Copyright 2016 Crown Copyright |
There was a problem hiding this comment.
Is the plan not to update the header as we're only reinstating things not strictly changing?
There was a problem hiding this comment.
Yes this PR is strictly a git revert, but you're right that date does need changing. I also don't like the fact the readme starts with a license when there is a separate license file.
There was a problem hiding this comment.
It feels like we need to rework the way the license stuff is managed more generally. Do these kind of files really need a header? For example, we don't have a header on every page of the docs.
There was a problem hiding this comment.
Yeah I am not sure, seems unnecessary and makes it harder to read for a readme.
* Revert "gh-951: Add deprecation note to readme (#952)" (#983) This reverts commit 94a4d38. * gh-984: Change usage of log4j to slf4j (#985) * gh-984: Change usage of log4j to slf4j * gh-984: Checkstyle * Updated Gaffer version to 1.22.0 (#990) * Updated Gaffer version to 1.22.0 * Gh-986: Migrate log4j to reload4j (#992) * gh-984: Change usage of log4j to slf4j * gh-984: Checkstyle * Exclude Log4j dependencies Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com> * gh-975: Fix gafferpy alpha 1 (#994) Co-authored-by: Gaffer <github-actions@github.com> Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com> * prepare release gaffer-tools-1.22.0 * prepare for next development iteration * Update links to point to v1docs (#999) * Graph layout is now saved when navigate away from page (#812) * Graph layout is now saved when navigate away from page * Fixed issue with old graph results still showing after clear * Updating removed elements to use concat * Updating to use forEach Updating removePreviouslyRemovedElements to use forEach * Updated syntax error * Altered foreach syntax due to jasmine errors * gh-496: Fix bug with concat Co-authored-by: t11947 <53758970+t11947@users.noreply.github.com> Co-authored-by: t92549 <80890692+t92549@users.noreply.github.com> * Add Deprecation message to UI README (#1061) * Updated Gaffer version to 1.23.0 (#1064) * Updated Gaffer version to 1.23.0 * CommonConstants replaced * Fixed js deps * Fixed js deps again * Original package.json --------- Co-authored-by: Gaffer <github-actions@github.com> * prepare release gaffer-tools-1.23.0 * prepare for next development iteration --------- Co-authored-by: Gaffer <github-actions@github.com> Co-authored-by: GCHQDeveloper314 <94527357+GCHQDeveloper314@users.noreply.github.com> Co-authored-by: p013570 <p013570@users.noreply.github.com> Co-authored-by: t11947 <53758970+t11947@users.noreply.github.com>
This reverts commit 94a4d38.
Related Issue