Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsolete GO:0000904 'cell morphogenesis involved in differentiation' #24299

Closed
balhoff opened this issue Oct 28, 2022 · 12 comments
Closed

obsolete GO:0000904 'cell morphogenesis involved in differentiation' #24299

balhoff opened this issue Oct 28, 2022 · 12 comments

Comments

@balhoff
Copy link
Member

balhoff commented Oct 28, 2022

@cmungall and I are adding some GCIs which help to infer extra part_of edges for morphogenesis in #24280. After adding this axiom:

anatomical structure morphogenesis and (results in morphogenesis of some cell) SubClassOf part of some
(anatomical structure development and (results in development of some cell))

we find that 'cell morphogenesis involved in differentiation' is logically equivalent to 'cell morphogenesis':

cell morphogenesis EquivalentTo cell morphogenesis involved in differentiation

We will also need to obsolete regulation of cell morphogenesis involved in differentiation.

@pgaudet
Copy link
Contributor

pgaudet commented Oct 31, 2022

Ontology call 2022-10-31

Agree on the obsoletion of GO:0000904 'cell morphogenesis involved in differentiation' - children can probably be rehoused under cellular component assembly + other terms.

@pgaudet
Copy link
Contributor

pgaudet commented Oct 31, 2022

Also; change term label 'cell morphogenesis involved in differentiation' to 'developmental cell morphogenesis', and this will be the genus of 'x cell morphogenesis'

@raymond91125
Copy link
Contributor

I am confused by the LD for the term cell morphogenesis involved in differentiation --
cell morphogenesis and (part of some cell development)
Shouldn't it be
cell morphogenesis and (part of some cell differentiation)?

image

Perhaps we should merge cell morphogenesis involved in differentiation into cell morphogenesis and also add a relationship cell morphogenesis PART_OF cell development.

@ukemi Do you think this makes sense?

@raymond91125
Copy link
Contributor

@balhoff does that PR solve the problems?

@balhoff
Copy link
Member Author

balhoff commented Jun 15, 2023

@raymond91125 @pgaudet possibly—I will need to update Chris's PR and check.

pgaudet added a commit that referenced this issue Jun 19, 2023
Changed LD of cell morphogenesis involved in differentiation. #24299
@pgaudet
Copy link
Contributor

pgaudet commented Jun 19, 2023

OK . I merged the PR.

Anyway this is an improvement!

Thanks, Pascale

@pgaudet
Copy link
Contributor

pgaudet commented Jul 10, 2023

Replacement terms for the regulation terms:

  • GO:0045595 regulation of cell differentiation
  • GO:0045596 negative regulation of cell differentiation
  • GO:0045597 positive regulation of cell differentiation

@raymond91125
Copy link
Contributor

@pgaudet I am confused. Shouldn't it be that:
GO:0000904 cell morphogenesis involved in differentiation 'merge into' GO:0000902 cell morphogenesis
GO:0010769 regulation of cell morphogenesis involved in differentiation 'merged into' GO:0022604 regulation of cell morphogenesis
There are no positive/negative regulation of cell morphogenesis terms
GO:0010771 negative regulation of cell morphogenesis involved in differentiation
GO:0010770 positive regulation of cell morphogenesis involved in differentiation

@pgaudet
Copy link
Contributor

pgaudet commented Jul 12, 2023

You are right, these are is_a morphogenesis, but since the term also has 'involved in' (ie, the relation we use to link gene products and GO terms), it seems both terms would be suitable.

But maybe it's safest to leave without a replacement, just 'consider'. There are 5 EXP, I appended to the review spreadsheet: https://docs.google.com/spreadsheets/d/1hvYeqnzHsyHq-IMHEAj-qOdipYR8dJocU90LceWwK1o/edit#gid=0

Does that work ?

Thanks, Pascale

@raymond91125
Copy link
Contributor

I believe the problem in the first place is that since cell morphogenesis must be part of cell differentiation, it is EquivalentTo cell morphogenesis involved in differentiation. That is, "cell morphogenesis involved in differentiation" is just another way of saying "cell morphogenesis". This is a true case of two terms that should be merged.
Moving annotations to cell differentiation may cause a loss of specificity as morphogenesis is a specific aspect of differentiation. Another aspect is function.

@raymond91125
Copy link
Contributor

The proposal is to
GO:0000904 cell morphogenesis involved in differentiation 'merge into' GO:0000902 cell morphogenesis
GO:0010769 regulation of cell morphogenesis involved in differentiation 'merged into' GO:0022604 regulation of cell morphogenesis
GO:0010771 negative regulation of cell morphogenesis involved in differentiation change label to negative regulation of cell morphogenesis
GO:0010770 positive regulation of cell morphogenesis involved in differentiation change label to positive regulation of cell morphogenesis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants