add partition key marker for Athena and Presto schemas #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push. |
jezdez
approved these changes
Aug 28, 2018
There was a problem hiding this comment.
Sorry, but this needs another pass, adding back the docstring. Thank you, @alison985!
Otherwise this is good to go!
| @@ -31,6 +31,21 @@ | |||
| } | |||
|
|
|||
|
|
|||
| # for athena and presto | |||
| def format_schema(results): | |||
| schema = {} | |||
There was a problem hiding this comment.
I'm sorry but the docstring changes from 17b9a0a didn't make it here, could you please add it?
| @@ -31,6 +31,21 @@ | |||
| } | |||
|
|
|||
|
|
|||
| # for athena and presto | |||
There was a problem hiding this comment.
No need to have this extra code comment.
jezdez
requested changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for: mozilla#430
ports the following upstream: https://github.com/mozilla/redash/pull/201/files
for previous code review see: #2655