Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

athena&presto support column type and partition key #3020

Closed
wants to merge 2 commits into from

Conversation

alison985
Copy link
Contributor

Original issue: mozilla#185
Original PR: mozilla#201

Issue to post this upstream: mozilla#430
Previous PR code reviews trying to port this upstream: #2655 #2764 #2826

This PR adds the key font awesome icon to partition keys and column type in the schema browser for Presto and Athena data sources.

Image (with forced partition key):
screenshot 2018-10-28 13 46 17

@jezdez
Copy link
Member

jezdez commented Nov 8, 2018

Diving into this more we found the overlap with #2990 too great to merge this PR first and will instead re-use the code later once #2990 has landed.

@jezdez jezdez closed this Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants