Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema viewer should expose partitioned columns #185

Closed
fbertsch opened this issue Aug 9, 2017 · 6 comments
Closed

Schema viewer should expose partitioned columns #185

fbertsch opened this issue Aug 9, 2017 · 6 comments
Assignees
@alison985
Milestone
9

Comments

@fbertsch
Copy link

fbertsch commented Aug 9, 2017

This only applies to tables which have partitions, i.e. just those in the Hive metastore (unless some RDBMS tables are sharded but... let's not go there). Exposing this information would make it easier to say to people "filter on partitions!" rather than have that be intimate knowledge for each dataset.
@alison985
Copy link

@fbertsch To make sure I'm understanding this right: in Hive data sources display to the user which columns there are partitions on. Perhaps with a [P] designation next to the field name?

@fbertsch
Copy link
Author

fbertsch commented Aug 10, 2017 •
edited
Loading

@alison985 right - here is an example DESCRIBE query output - I've highlighted the partitions descriptions: https://pastebin.mozilla.org/9029373

[P] could work, something that goes along with whatever the schema browser's type information looks like (which I haven't seen yet).

@rafrombrc rafrombrc added this to the 9 milestone Aug 10, 2017
@alison985
Copy link

@fbertsch That pastebin doesn't work for me. Could you try again or another way please?

@fbertsch
Copy link
Author

@alison985 https://pastebin.mozilla.org/9029674

@alison985 alison985 self-assigned this Aug 14, 2017
alison985 added a commit to alison985/mozilla-redash that referenced this issue Aug 14, 2017
@alison985
add partition key marker to partition columns
f4d5830 
mozilla#185

added to the front of the column name so they are in a consistent
ordinal position for each table

tests pass
@alison985 alison985 mentioned this issue Aug 14, 2017
Merged
@alison985
Copy link

Thanks. PR #201

@madalincm
Copy link

I'm not sure how to verify this bug. @alison985 Can you please provide some steps on how I should proceed verifying this issue?

washort pushed a commit that referenced this issue Dec 12, 2017
add partition key marker to Athena and Presto columns (re #185)
b77b736
washort pushed a commit that referenced this issue Dec 12, 2017
add partition key marker to Athena and Presto columns (re #185)
7037603
washort pushed a commit that referenced this issue Dec 13, 2017
@alison985
add partition key marker to partition columns
d50274f 
#185

added to the front of the column name so they are in a consistent
ordinal position for each table

tests pass
washort pushed a commit that referenced this issue Jan 8, 2018
add partition key marker to Athena and Presto columns (re #185)
84e7c76
washort pushed a commit that referenced this issue Feb 28, 2018
add partition key marker to Athena and Presto columns (re #185)
6f4a523
jezdez pushed a commit that referenced this issue Mar 5, 2018
@jezdez
add partition key marker to Athena and Presto columns (re #185)
0746ebf
emtwo pushed a commit that referenced this issue May 25, 2018
add partition key marker to Athena and Presto columns (re #185)
d8182ab
@jezdez jezdez mentioned this issue Jun 19, 2018
Closed
@alison985 alison985 mentioned this issue Jun 30, 2018
Open
washort pushed a commit that referenced this issue Jul 25, 2018
add partition key marker to Athena and Presto columns (re #185)
ac4a36e
washort pushed a commit that referenced this issue Jul 30, 2018
add partition key marker to Athena and Presto columns (re #185)
7ec6851
jezdez pushed a commit that referenced this issue Aug 16, 2018
@jezdez
add partition key marker to Athena and Presto columns (re #185)
8134845
jezdez pushed a commit that referenced this issue Sep 6, 2018
@jezdez
add partition key marker to Athena and Presto columns (re #185)
cc4f27f
jezdez pushed a commit that referenced this issue Sep 6, 2018
@jezdez
add partition key marker to Athena and Presto columns (re #185)
07346c7
@alison985 alison985 mentioned this issue Sep 17, 2018
Closed
@alison985 alison985 mentioned this issue Oct 28, 2018
Closed
jezdez pushed a commit that referenced this issue Nov 1, 2018
@jezdez
add partition key marker to Athena and Presto columns (re #185)
576cf34
jezdez pushed a commit that referenced this issue Dec 12, 2018
@jezdez
Add partition key marker to Athena and Presto columns (re #185)
e8e2616
jezdez pushed a commit that referenced this issue Dec 17, 2018
@jezdez
Add partition key marker to Athena and Presto columns (re #185)
d8c8eea
jezdez pushed a commit that referenced this issue Dec 19, 2018
@jezdez
Add partition key marker to Athena and Presto columns (re #185)
3d4acd8
jezdez pushed a commit that referenced this issue Jan 25, 2019
@jezdez
Add partition key marker to Athena and Presto columns (re #185)
d440b80
@MaxMood96 MaxMood96 mentioned this issue Nov 5, 2022
Open
@MaxMood96 MaxMood96 mentioned this issue Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alison985 alison985

Labels
None yet
Projects
None yet
Milestone
9
Development

No branches or pull requests
4 participants
@rafrombrc @alison985 @madalincm @fbertsch