Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port partition key marker (Athena/Presto) to upstream #430

Closed
jezdez opened this issue Jun 19, 2018 · 6 comments
Closed

Port partition key marker (Athena/Presto) to upstream #430

jezdez opened this issue Jun 19, 2018 · 6 comments
Assignees
@alison985
Labels
in review upstream PR in review in getredash/redash port upstream whether this needs to be ported upstream
Milestone
18

Comments

@jezdez
Copy link

jezdez commented Jun 19, 2018 •
edited
Loading

Add partition key marker to Athena and Presto columns (#185, PR: #201)

This is tracked on https://github.com/mozilla/redash/projects/3
@jezdez jezdez added the port upstream whether this needs to be ported upstream label Jun 19, 2018
@alison985 alison985 mentioned this issue Jun 30, 2018
Open
@alison985
Copy link

upstream PR getredash#2655

@alison985 alison985 self-assigned this Jun 30, 2018
@alison985 alison985 added in review upstream PR in review in getredash/redash in progress labels Jul 8, 2018
@alison985 alison985 added this to the 16 milestone Jul 11, 2018
@rafrombrc rafrombrc modified the milestones: 16, 17 Aug 9, 2018
@alison985 alison985 mentioned this issue Aug 26, 2018
Closed
@alison985
Copy link

Revised PR getredash#2764

@alison985 alison985 added ready and removed blocked labels Sep 10, 2018
@alison985
Copy link

Next steps:

  • Extend query runner base class to include hook (method) that can be used to design the output of the schema browser, per query runner type.
  • Improve UX with icon not [P]

@alison985 alison985 mentioned this issue Sep 17, 2018
Closed
@alison985
Copy link

upstream PR: getredash#2826
Has a Javascript problem with autocomplete at the moment.

@alison985 alison985 mentioned this issue Oct 28, 2018
Closed
@alison985
Copy link

New upstream PR getredash#3020

@rafrombrc rafrombrc modified the milestones: 17, 18 Nov 7, 2018
@rafrombrc
Copy link
Member

We've decided to retract the upstream PR because this functionality can be rolled into the bigger schema browser improvements that Marina is currently working on. We'll still keep this implementation in our fork until that lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alison985 alison985

Labels
in review upstream PR in review in getredash/redash port upstream whether this needs to be ported upstream
Projects
None yet
Milestone
18
Development

No branches or pull requests
3 participants
@jezdez @rafrombrc @alison985