-
-
Notifications
You must be signed in to change notification settings - Fork 371
chore(ci): Add consistent job naming #5810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ad626fb to
2460a25
Compare
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cd9727b | 1236.04 ms | 1254.41 ms | 18.37 ms |
| 354b020 | 1223.88 ms | 1236.82 ms | 12.94 ms |
| d06a4db | 1233.20 ms | 1243.18 ms | 9.98 ms |
| 134fbdf | 1219.71 ms | 1240.35 ms | 20.64 ms |
| 795dd39 | 1216.88 ms | 1245.47 ms | 28.59 ms |
| 76f74df | 1238.29 ms | 1261.22 ms | 22.94 ms |
| 2a07609 | 1207.79 ms | 1233.77 ms | 25.98 ms |
| 438caec | 1230.02 ms | 1250.00 ms | 19.98 ms |
| 1b9991e | 1233.45 ms | 1256.61 ms | 23.17 ms |
| d0f70ce | 1226.54 ms | 1247.04 ms | 20.50 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cd9727b | 23.75 KiB | 879.25 KiB | 855.51 KiB |
| 354b020 | 23.75 KiB | 878.19 KiB | 854.44 KiB |
| d06a4db | 23.75 KiB | 913.18 KiB | 889.43 KiB |
| 134fbdf | 23.75 KiB | 875.25 KiB | 851.50 KiB |
| 795dd39 | 23.75 KiB | 908.16 KiB | 884.41 KiB |
| 76f74df | 23.75 KiB | 879.61 KiB | 855.86 KiB |
| 2a07609 | 23.75 KiB | 912.78 KiB | 889.03 KiB |
| 438caec | 23.74 KiB | 913.14 KiB | 889.40 KiB |
| 1b9991e | 23.75 KiB | 908.01 KiB | 884.26 KiB |
| d0f70ce | 23.75 KiB | 913.09 KiB | 889.34 KiB |
|
cursor review |
|
@sentry review |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Make the test requirements less strict by removing the assert of the blocking duration and adding a test expectation timing out after 10 seconds to prevent hanging CI if the flush blocks longer.
Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5810 +/- ##
=============================================
+ Coverage 86.599% 86.643% +0.043%
=============================================
Files 423 423
Lines 36364 36364
Branches 17181 17185 +4
=============================================
+ Hits 31491 31507 +16
+ Misses 4826 4812 -14
+ Partials 47 45 -2 see 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR standardizes GitHub Actions workflow job naming to prepare for required status checks which rely on consistent job names. The changes focus on making job names concise, action-oriented, and version-agnostic while maintaining flaky test tracking functionality.
- Updates job names across all workflow files to follow consistent naming conventions
- Restructures matrix configurations to include descriptive name fields for better job identification
- Adds a comprehensive naming convention guide for future workflow development
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ui-tests.yml |
Updates UI test job names and adds descriptive matrix names for better identification |
.github/workflows/ui-tests-critical.yml |
Standardizes critical UI test job naming and restructures matrix configuration |
.github/workflows/test.yml |
Simplifies unit test job names and adds descriptive matrix entries |
.github/workflows/test-cross-platform.yml |
Updates workflow and job names for cross-platform testing |
.github/workflows/release.yml |
Adds missing job names and standardizes release workflow naming |
.github/workflows/lint-*.yml |
Standardizes lint workflow names and job naming across all lint workflows |
.github/workflows/integration-test.yml |
Updates CocoaPods integration test naming |
.github/workflows/danger.yml |
Adds missing job name for Danger workflow |
.github/workflows/codeql-analysis.yml |
Updates CodeQL job name to include matrix variable |
.github/workflows/changes-in-high-risk-code.yml |
Adds missing job names and improves descriptions |
.github/workflows/build-xcframework-variant-slices.yml |
Simplifies workflow name |
.github/workflows/benchmarking.yml |
Updates benchmarking job names for consistency |
.github/workflows/assemble-xcframework-variant.yml |
Simplifies workflow and job names |
.github/workflows/api-stability.yml |
Adds missing job name with matrix variable |
.cursor/rules/github-workflow.mdc |
Adds comprehensive naming convention guide for GitHub workflows |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 times better than what we had previously and long overdue. Thanks a lot @philprime 🥇
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
This reverts commit d3b0d62.
This reverts commit d3b0d62.
This PR updates the naming of jobs in preparation for required status checks (which use reported job names).
This PR should not change the jobs themselves, nor the path-related triggers to run jobs.To clarify, this PR does split some of the linting jobs into separate workflows, but the amount of work performed is the same.
#skip-changelog