Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Aug 5, 2025

This PR updates the naming of jobs in preparation for required status checks (which use reported job names).

This PR should not change the jobs themselves, nor the path-related triggers to run jobs.

To clarify, this PR does split some of the linting jobs into separate workflows, but the amount of work performed is the same.

#skip-changelog

@philprime philprime self-assigned this Aug 5, 2025
@philprime philprime force-pushed the philprime/clean-job-naming branch from ad626fb to 2460a25 Compare August 5, 2025 12:52
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.94 ms 1238.98 ms 3.04 ms
Size 23.75 KiB 913.14 KiB 889.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
cd9727b 1236.04 ms 1254.41 ms 18.37 ms
354b020 1223.88 ms 1236.82 ms 12.94 ms
d06a4db 1233.20 ms 1243.18 ms 9.98 ms
134fbdf 1219.71 ms 1240.35 ms 20.64 ms
795dd39 1216.88 ms 1245.47 ms 28.59 ms
76f74df 1238.29 ms 1261.22 ms 22.94 ms
2a07609 1207.79 ms 1233.77 ms 25.98 ms
438caec 1230.02 ms 1250.00 ms 19.98 ms
1b9991e 1233.45 ms 1256.61 ms 23.17 ms
d0f70ce 1226.54 ms 1247.04 ms 20.50 ms

App size

Revision Plain With Sentry Diff
cd9727b 23.75 KiB 879.25 KiB 855.51 KiB
354b020 23.75 KiB 878.19 KiB 854.44 KiB
d06a4db 23.75 KiB 913.18 KiB 889.43 KiB
134fbdf 23.75 KiB 875.25 KiB 851.50 KiB
795dd39 23.75 KiB 908.16 KiB 884.41 KiB
76f74df 23.75 KiB 879.61 KiB 855.86 KiB
2a07609 23.75 KiB 912.78 KiB 889.03 KiB
438caec 23.74 KiB 913.14 KiB 889.40 KiB
1b9991e 23.75 KiB 908.01 KiB 884.26 KiB
d0f70ce 23.75 KiB 913.09 KiB 889.34 KiB

Previous results on branch: philprime/clean-job-naming

Startup times

Revision Plain With Sentry Diff
1c53017 1211.43 ms 1232.42 ms 20.99 ms

App size

Revision Plain With Sentry Diff
1c53017 23.74 KiB 913.38 KiB 889.64 KiB

@philprime
Copy link
Member Author

cursor review

@philprime philprime requested a review from Copilot August 6, 2025 12:57
@philprime
Copy link
Member Author

@sentry review

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@philprime philprime requested a review from Copilot August 6, 2025 13:19

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.643%. Comparing base (1e59a45) to head (3960a02).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5810       +/-   ##
=============================================
+ Coverage   86.599%   86.643%   +0.043%     
=============================================
  Files          423       423               
  Lines        36364     36364               
  Branches     17181     17185        +4     
=============================================
+ Hits         31491     31507       +16     
+ Misses        4826      4812       -14     
+ Partials        47        45        -2     

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e59a45...3960a02. Read the comment docs.

@philprime philprime requested a review from Copilot August 7, 2025 09:12
@philprime
Copy link
Member Author

cursor review

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes GitHub Actions workflow job naming to prepare for required status checks which rely on consistent job names. The changes focus on making job names concise, action-oriented, and version-agnostic while maintaining flaky test tracking functionality.

  • Updates job names across all workflow files to follow consistent naming conventions
  • Restructures matrix configurations to include descriptive name fields for better job identification
  • Adds a comprehensive naming convention guide for future workflow development

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/ui-tests.yml Updates UI test job names and adds descriptive matrix names for better identification
.github/workflows/ui-tests-critical.yml Standardizes critical UI test job naming and restructures matrix configuration
.github/workflows/test.yml Simplifies unit test job names and adds descriptive matrix entries
.github/workflows/test-cross-platform.yml Updates workflow and job names for cross-platform testing
.github/workflows/release.yml Adds missing job names and standardizes release workflow naming
.github/workflows/lint-*.yml Standardizes lint workflow names and job naming across all lint workflows
.github/workflows/integration-test.yml Updates CocoaPods integration test naming
.github/workflows/danger.yml Adds missing job name for Danger workflow
.github/workflows/codeql-analysis.yml Updates CodeQL job name to include matrix variable
.github/workflows/changes-in-high-risk-code.yml Adds missing job names and improves descriptions
.github/workflows/build-xcframework-variant-slices.yml Simplifies workflow name
.github/workflows/benchmarking.yml Updates benchmarking job names for consistency
.github/workflows/assemble-xcframework-variant.yml Simplifies workflow and job names
.github/workflows/api-stability.yml Adds missing job name with matrix variable
.cursor/rules/github-workflow.mdc Adds comprehensive naming convention guide for GitHub workflows

cursor[bot]

This comment was marked as outdated.

@philprime philprime marked this pull request as ready for review August 7, 2025 09:21
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 times better than what we had previously and long overdue. Thanks a lot @philprime 🥇

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/workflows/changes-in-high-risk-code.yml

@philprime philprime added the Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks. label Aug 7, 2025
@philprime philprime merged commit d3b0d62 into main Aug 7, 2025
126 of 127 checks passed
@philprime philprime deleted the philprime/clean-job-naming branch August 7, 2025 11:31
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants