meta(changelog): Update changelog for v8.2.0 #12073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests a node app that uses ESM, but no `--import` flag. Somehow this works for `http` (but not other packages...) but this is fine for errors-only mode, for now. Missing: We do show the warning for missing express instrumentation there, still 😬 we may need to tweak this...
Closes #12051 This PR does two things: 1. Ensures we add helpful attributes to idle spans more consistently. We now add the `sentry.idle_span_finish_reason` attribute always for idle spans, not only when op == `ui.action.click`. This should also make it easier to debug stuff etc, and I see no reason to not always set this. Additionally, we also keep the number of spans we discarded (if any) for easier debugging too (as `sentry.idle_span_discarded_spans`). 2. We ensure that idle spans cannot exceed the configured `finalTimeout`. Previously, due to the order of things, it was possible that we ended a span very late, if it had a child span with a very late end timestamp (as we took the last child span timestamp). Possibly this could lead to overly long transactions. I think 2, combined with the fact that later we _do_ filter out child spans that ended after idle span, lead to the incorrect-length spans.
ref #12034 cc @AbhiPrasad when you're back, let's look again at `hasTracingEnabled()` and see if we want to adjust this maybe.
In some places we used `Date.now()`, instead of `timestampInSeconds()` which used performance.now(). There are still other places where we use `Date.now()`, esp. in replay and node, but I focused on regular browser stuff for now (because this is most likely to be affected by this).
[Gitflow] Merge master into develop
Actually we should check for the changelog commit, which we look for by checking `-meta` and `changelog` in the commit message. (Not perfect, but good enough hopefully...) I noticed it was not correctly picking up all commits while a release was in progress before.
…#12071) We noticed that in http integration, we were only setting `transactionName` when we had a sampled span. We can actually set this based on the request object we get either way, making this more robust for error-only mode.
…ource maps generation (#12072) Now we can at least recommend to use `filesToDeleteAfterUpload` since we bumped to vite plugin 2.x with 8.0.0
…ands) (#12070) Populates the OTel span with cache attributes. Currently, `get` and `set` commands are considered. --------- Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
andreiborza
approved these changes
May 16, 2024
mydea
force-pushed
the
prepare-release/8.2.0
branch
from
308947c to
46511e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on #12070