Skip to content

feat(tracing): Add tracing-internal package #7418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 11, 2023

This PR:

  • Adds a tracing-internal package
  • Moves all the code (minus side-effects) from @sentry/tracing to tracing-internal
  • Moves tests that require private types to tracing-internal
  • Ensures BrowserTracing is exported separately from tracing-internal for tree-shaking

@timfish
Copy link
Collaborator Author

timfish commented Mar 11, 2023

The build passes fine on my machine. I've tried clearing the nx cache locally and get the same 🤔.

Instead of attempting to bundle the private @sentry-internal/tracing code into @sentry/tracing and getting all the typescript definitions bundled too... how about making @sentry-internal/tracing public and publishing it. It would be a lot less work for what is only a stop-gap solution.

@timfish timfish changed the title feat(tracing): Add tracing-internal private package feat(tracing): Add tracing-internal package Mar 12, 2023
@AbhiPrasad
Copy link
Member

how about making @sentry-internal/tracing public and publishing it

let's just do this - we can leave a note in the readme that nobody should be installing this - and we don't have to publish it in the release registry.

@timfish
Copy link
Collaborator Author

timfish commented Mar 13, 2023

@timfish timfish closed this Mar 13, 2023
@timfish timfish deleted the feat/tracing-internal branch March 14, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants