Skip to content

feat(tracing): Add @sentry-internal/tracing package #7445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 13, 2023

Ref #5815.

This PR adds the internal @sentry-internal/tracing package.

A later PR will move the code from @sentry/tracing into this new package and re-export the types without causing any breaking changes.

@timfish timfish marked this pull request as ready for review March 13, 2023 21:32
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timfish
Copy link
Collaborator Author

timfish commented Mar 14, 2023

Those docs say:

Before the Release:
2) Make sure that the new SDK is not added in craft.yml as a target for the Sentry release registry

After the Release
2) Add an entry to craft.yml to add releases of your SDK to the Sentry release registry

You did suggest previously that we don't add this new package to the registry.

@AbhiPrasad
Copy link
Member

you are totally right Tim, we don't need this - I'm in too many places at once 😅

Thanks for the reminder!

@AbhiPrasad AbhiPrasad merged commit 80b6939 into getsentry:develop Mar 14, 2023
@timfish timfish deleted the feat/add-tracing-internal branch March 14, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants