Skip to content

feat(tracing): Move tracing code to internal package #7451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 14, 2023
Merged

feat(tracing): Move tracing code to internal package #7451

merged 7 commits into from
Mar 14, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 13, 2023 •
edited
Loading

Built on top of #7445 which needs to be merged first.

Ref #5815

  • Moves all the code (minus side-effects) from @sentry/tracing to tracing-internal
  • Moves tests that require private types to tracing-internal
  • Ensures BrowserTracing is exported separately from Integrations in tracing-internal for tree-shaking

I guess there could be a further PR after this to do some more cleanup, like moving the definition of Integrations from tracing-internal to @sentry/tracing.

@timfish timfish mentioned this pull request Mar 13, 2023
Closed
4 tasks
@timfish timfish force-pushed the feat/move-tracing-to-internal branch from 07f2d8f to 3f527c9 Compare March 13, 2023 22:29
@timfish timfish marked this pull request as ready for review March 14, 2023 15:32
@timfish timfish requested a review from AbhiPrasad March 14, 2023 16:10
AbhiPrasad
AbhiPrasad reviewed Mar 14, 2023
View reviewed changes
packages/tracing/package.json
"@sentry/core": "7.43.0",
"@sentry/types": "7.43.0",
"@sentry/utils": "7.43.0",
"tslib": "^1.9.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we still need tslib here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not!

@AbhiPrasad AbhiPrasad merged commit 2f886f6 into getsentry:develop Mar 14, 2023
@timfish timfish deleted the feat/move-tracing-to-internal branch March 14, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @AbhiPrasad