Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(grouping): Added initial pass of new grouping algorithm #12414

Merged
merged 7 commits into from
Mar 18, 2019

Conversation

mitsuhiko
Copy link
Member

@mitsuhiko mitsuhiko commented Mar 15, 2019

This PR introduces a new grouping strategy which is currently called new:wip which simplifies the old grouping algorithm. It does not attempt to be compatible with the old one and it's not intended to become a production ready grouping algorithm but is a temporary experiment.

@mitsuhiko mitsuhiko requested a review from jan-auer March 18, 2019 08:26
@mitsuhiko mitsuhiko changed the title ref(grouping): Added initial pass of new grouping algorithm (WIP) ref(grouping): Added initial pass of new grouping algorithm Mar 18, 2019
@mitsuhiko
Copy link
Member Author

This can be safely merged as it.

Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😓

@mitsuhiko mitsuhiko merged commit 384733c into master Mar 18, 2019
@mitsuhiko mitsuhiko deleted the feature/grouping-evolution branch March 18, 2019 08:46
jan-auer added a commit that referenced this pull request Mar 19, 2019
* master: (36 commits)
  Revert "feat(app-platform): Open in stacktrace button (#12401)"
  fix(app-platform): Unsubscribe from Store changes (#12445)
  feat(app-platform): Open in stacktrace button (#12401)
  ref(project transfer): Add explanatory sentence to modal (#12427)
  feat(features): Add org saved searches [SEN-355] (#12441)
  add project to payload (#12407)
  feat(app-platform): Issue Link UI (#12345)
  fix(api): Fix bug where parser didn't allow dates ending in `Z`, and didn't correctly report the parse fail to the user (ISSUE-376)
  Add enhanced privacy to feedback (#12418)
  fix: Add sentry tag to renormalized events (#12434)
  dev: Ensure docker binds to an interface
  EventCommon mixin for common event functionality (#12422)
  build(webpack): Only show errors in webpack output (#12425)
  ref(ui): Remove unused utils (#12424)
  ref: Sample to_python calls 2 (#12375)
  feat(eventtypes): Keep value retained for synthetic errors (#12355)
  fix: Fix UI side to deal with invalid values (#12433)
  ref(grouping): Added initial pass of new grouping algorithm (#12414)
  build(webpack): Fix incremental webpack builds (upgrade to node@8.15.1) (#12408)
  Revert "feat: Common functionality for Snuba Events (#11071)" (#12421)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants