fix(app-platform): Unsubscribe from Store changes #12445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was using the interface for unsubscribing from Reflux actions, whereas we're just using the action-less version of Reflux. It changes that unsubscribing code to match what we're using. FIXES JAVASCRIPT-5SC
MeredithAnya
approved these changes
Mar 18, 2019
jan-auer
added a commit
that referenced
this pull request
Mar 19, 2019
* master: (36 commits) Revert "feat(app-platform): Open in stacktrace button (#12401)" fix(app-platform): Unsubscribe from Store changes (#12445) feat(app-platform): Open in stacktrace button (#12401) ref(project transfer): Add explanatory sentence to modal (#12427) feat(features): Add org saved searches [SEN-355] (#12441) add project to payload (#12407) feat(app-platform): Issue Link UI (#12345) fix(api): Fix bug where parser didn't allow dates ending in `Z`, and didn't correctly report the parse fail to the user (ISSUE-376) Add enhanced privacy to feedback (#12418) fix: Add sentry tag to renormalized events (#12434) dev: Ensure docker binds to an interface EventCommon mixin for common event functionality (#12422) build(webpack): Only show errors in webpack output (#12425) ref(ui): Remove unused utils (#12424) ref: Sample to_python calls 2 (#12375) feat(eventtypes): Keep value retained for synthetic errors (#12355) fix: Fix UI side to deal with invalid values (#12433) ref(grouping): Added initial pass of new grouping algorithm (#12414) build(webpack): Fix incremental webpack builds (upgrade to node@8.15.1) (#12408) Revert "feat: Common functionality for Snuba Events (#11071)" (#12421) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was using the interface for unsubscribing from Reflux actions, whereas we're just using the action-less version of Reflux. It changes that unsubscribing code to match what we're using.
FIXES JAVASCRIPT-5SC