ref(feedback): Add enhanced privacy to feedback alerts #12418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
reviewed
Mar 18, 2019
| @@ -4,8 +4,14 @@ | |||
|
|
|||
| {{ report.name }} left a new comment: | |||
There was a problem hiding this comment.
Is it ok to display the reporter's name if enhanced privacy is enabled?
There was a problem hiding this comment.
Probably our call. The company requesting this said they're fine with the username -- only concerned about the content of the feedback being hidden.
There was a problem hiding this comment.
It's probably fine for now then, maybe a product decision.
| @@ -28,7 +28,7 @@ <h2>{{ activity_name }}</h2> | |||
|
|
|||
| {% endblock %} | |||
|
|
|||
| {% if group %} | |||
| {% if group and not enhanced_privacy %} | |||
There was a problem hiding this comment.
Why do we hide the group information here?
There was a problem hiding this comment.
The enhanced privacy setting says it hides PII and source code. Does the stacktrace in the group information count as source code?
There was a problem hiding this comment.
Yep, definitely would. Sounds good to hide it here then!
wedamija
approved these changes
Mar 18, 2019
mitsuhiko
pushed a commit
that referenced
this pull request
Mar 18, 2019
jan-auer
added a commit
that referenced
this pull request
Mar 19, 2019
* master: (36 commits) Revert "feat(app-platform): Open in stacktrace button (#12401)" fix(app-platform): Unsubscribe from Store changes (#12445) feat(app-platform): Open in stacktrace button (#12401) ref(project transfer): Add explanatory sentence to modal (#12427) feat(features): Add org saved searches [SEN-355] (#12441) add project to payload (#12407) feat(app-platform): Issue Link UI (#12345) fix(api): Fix bug where parser didn't allow dates ending in `Z`, and didn't correctly report the parse fail to the user (ISSUE-376) Add enhanced privacy to feedback (#12418) fix: Add sentry tag to renormalized events (#12434) dev: Ensure docker binds to an interface EventCommon mixin for common event functionality (#12422) build(webpack): Only show errors in webpack output (#12425) ref(ui): Remove unused utils (#12424) ref: Sample to_python calls 2 (#12375) feat(eventtypes): Keep value retained for synthetic errors (#12355) fix: Fix UI side to deal with invalid values (#12433) ref(grouping): Added initial pass of new grouping algorithm (#12414) build(webpack): Fix incremental webpack builds (upgrade to node@8.15.1) (#12408) Revert "feat: Common functionality for Snuba Events (#11071)" (#12421) ...
mitsuhiko
added a commit
that referenced
this pull request
Mar 20, 2019
…12432) * feat(grouping): Add project option to force grouping and persit it * feat(grouping): Expose the grouping config forcing through the api * ref: Improved grouping config selectiong * feat(grouping): Add grouping config to the UI (feature flagged) * meta: Bump semaphore to 0.4.20 * ref: Move grouping config freeze into normalize and change apis * ref: Cleaned up config code * ref: Add config ID to the grouping info output * fix(api): Fix bug where parser didn't allow dates ending in `Z`, and didn't correctly report the parse fail to the user (ISSUE-376) Our parser didn't allow for dates with `Z` at the end, so updated the regex to allow. Also fixed a bug where if a date started with a valid date but ended with invalid input then we'd create a search filter from the valid input, then shove the invalid input into `message` rather than raising a parse error. Fixes (ISSUE-376) * Add enhanced privacy to feedback (#12418) * feat(app-platform): Issue Link UI (#12345) This change takes care of dynamically rendering the Link and Create forms for Sentry Apps that support Issue Link components. * add project to payload (#12407) * feat: Added grouping selector on grouping info page * feat: Added tooltip * test: Improve test coverage for grouping * ref: Slightly improved native grouping * ref: More cleanup in new grouping algorithm * ref: rename a misnamed function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the organization enhanced privacy flag is enabled, hide user feedback comments in email notifications. For healthcare companies, for example, PHI can be left in user feedback and shouldn't be sent via email.