ref(metrics): Remove performance.index-tag-values option flag
#53870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
john-z-yang
force-pushed
the
john/remove-itv
branch
from
b1d9e78
to
5906d69
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53870 +/- ##
==========================================
- Coverage 79.53% 79.53% -0.01%
==========================================
Files 4965 4965
Lines 209829 209827 -2
Branches 35721 35721
==========================================
- Hits 166893 166889 -4
- Misses 37812 37813 +1
- Partials 5124 5125 +1
|
john-z-yang
changed the title
performance.index-tag-values option flag
ayirr7
reviewed
Jul 31, 2023
| @@ -42,7 +42,7 @@ class MetricsIngestConfiguration: | |||
| cardinality_limiter_cluster_options: Mapping[str, Any] | |||
| cardinality_limiter_namespace: str | |||
|
|
|||
| index_tag_values_option_name: Optional[str] = None | |||
| should_index_tag_values: bool = False | |||
There was a problem hiding this comment.
small q, should this be Optional[bool] = False?
There was a problem hiding this comment.
I don't think it should, since the default is set to False and it should either be True or False and never None
There was a problem hiding this comment.
Nit: Though it does not change the behavior, it might be better to not have a default. Let each configuration explicitly set it following the general rule Explicit is better than implicit.
nikhars
approved these changes
Jul 31, 2023
| @@ -42,7 +42,7 @@ class MetricsIngestConfiguration: | |||
| cardinality_limiter_cluster_options: Mapping[str, Any] | |||
| cardinality_limiter_namespace: str | |||
|
|
|||
| index_tag_values_option_name: Optional[str] = None | |||
| should_index_tag_values: bool = False | |||
There was a problem hiding this comment.
Nit: Though it does not change the behavior, it might be better to not have a default. Let each configuration explicitly set it following the general rule Explicit is better than implicit.
jan-auer
added a commit
that referenced
this pull request
Aug 2, 2023
* master: (660 commits) fix(starfish): Improve time spent column formatting (#53989) fix(starfish): Improve span table columns (#53988) fix(starfish): Remove unnecessary wrapper around span description (#53986) ref(getting-started-docs): Make project deletion onBack enabled by default (#54020) ref(getting-started-docs): Make project deletion onBack enabled by default (#54019) chore(spans): Add feature flag for span extraction (#53925) ref(backpressure): Bump rabbit http request timeout (#54014) chore(test): Update tests/js/sentry-test/charts.tsx to TypeScript (#54010) ref(merged-pr-comments): Add a couple of metrics to track successes (#53981) fix(hc): Fix split DB test failures (#53907) migration(crons): Backfill next check-in latest (#53984) ref(crons): Match environment label color to icon color in timeline row (#53977) Stop publishing to PyPI (#53980) ref(alerts): Soft deprecate projectalertruledetails delete method (#53970) fix(hc): Stabilize OrganizationRepositoryDeleteTest (#53668) ref(replays): change widgets to be rage & dead clicks (#53982) fix(github-growth): catch and raise RepoExistsError (#53946) feat(root-cause-analysis): Add feature flag (#53955) feat(helpful-event): Add back trace.sampled to sort (#53936) ref(metrics): Remove `performance.index-tag-values` option flag (#53870) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes the
performance.index-tag-valuesoption flag since performance metrics should always never index their tag values.