Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(starfish): Improve span table columns #53988

Merged
merged 3 commits into from
Aug 2, 2023
Merged

fix(starfish): Improve span table columns #53988

merged 3 commits into from
Aug 2, 2023

Conversation

gggritso
Copy link
Member

@gggritso gggritso commented Aug 1, 2023

  • Average --> AVG
  • Queries --> Queries Per Min
  • Database Query --> Query Description

@gggritso gggritso requested a review from a team August 1, 2023 21:44
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 1, 2023
@gggritso gggritso merged commit d716da4 into master Aug 2, 2023
@gggritso gggritso deleted the fix/starfish/better-span-table-columns branch August 2, 2023 14:08
jan-auer added a commit that referenced this pull request Aug 2, 2023
@jan-auer
Merge branch 'master' into feat/add-experimental-metrics-queries
d910450 
* master: (660 commits)
  fix(starfish): Improve time spent column formatting (#53989)
  fix(starfish): Improve span table columns (#53988)
  fix(starfish): Remove unnecessary wrapper around span description (#53986)
  ref(getting-started-docs): Make project deletion onBack enabled by default (#54020)
  ref(getting-started-docs): Make project deletion onBack enabled by default (#54019)
  chore(spans): Add feature flag for span extraction (#53925)
  ref(backpressure): Bump rabbit http request timeout (#54014)
  chore(test): Update tests/js/sentry-test/charts.tsx to TypeScript (#54010)
  ref(merged-pr-comments): Add a couple of metrics to track successes (#53981)
  fix(hc): Fix split DB test failures (#53907)
  migration(crons): Backfill next check-in latest (#53984)
  ref(crons): Match environment label color to icon color in timeline row (#53977)
  Stop publishing to PyPI (#53980)
  ref(alerts): Soft deprecate projectalertruledetails delete method (#53970)
  fix(hc): Stabilize OrganizationRepositoryDeleteTest (#53668)
  ref(replays): change widgets to be rage & dead clicks (#53982)
  fix(github-growth): catch and raise RepoExistsError (#53946)
  feat(root-cause-analysis): Add feature flag (#53955)
  feat(helpful-event): Add back trace.sampled to sort (#53936)
  ref(metrics): Remove `performance.index-tag-values` option flag (#53870)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gggritso @AbhiPrasad