fix(github-growth): catch and raise RepoExistsError #53946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #53946 +/- ##
==========================================
- Coverage 79.54% 79.53% -0.01%
==========================================
Files 4974 4974
Lines 210291 210395 +104
Branches 35817 35836 +19
==========================================
+ Hits 167268 167341 +73
- Misses 37872 37905 +33
+ Partials 5151 5149 -2
|
github-actions
bot
added
the
Scope: Backend
cathteng
changed the title
AniketDas-Tekky
approved these changes
Aug 1, 2023
jan-auer
added a commit
that referenced
this pull request
Aug 2, 2023
* master: (660 commits) fix(starfish): Improve time spent column formatting (#53989) fix(starfish): Improve span table columns (#53988) fix(starfish): Remove unnecessary wrapper around span description (#53986) ref(getting-started-docs): Make project deletion onBack enabled by default (#54020) ref(getting-started-docs): Make project deletion onBack enabled by default (#54019) chore(spans): Add feature flag for span extraction (#53925) ref(backpressure): Bump rabbit http request timeout (#54014) chore(test): Update tests/js/sentry-test/charts.tsx to TypeScript (#54010) ref(merged-pr-comments): Add a couple of metrics to track successes (#53981) fix(hc): Fix split DB test failures (#53907) migration(crons): Backfill next check-in latest (#53984) ref(crons): Match environment label color to icon color in timeline row (#53977) Stop publishing to PyPI (#53980) ref(alerts): Soft deprecate projectalertruledetails delete method (#53970) fix(hc): Stabilize OrganizationRepositoryDeleteTest (#53668) ref(replays): change widgets to be rage & dead clicks (#53982) fix(github-growth): catch and raise RepoExistsError (#53946) feat(root-cause-analysis): Add feature flag (#53955) feat(helpful-event): Add back trace.sampled to sort (#53936) ref(metrics): Remove `performance.index-tag-values` option flag (#53870) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
self.handle_api_error(e)is called ande = RepoExistsError, the error is not explicitly checked for inhandle_api_errorand it returns a generic 500. If we raise the exception itself, we will get a 400.This should help reduce the number of issues like https://sentry.sentry.io/issues/4311119036/?project=1