Skip to content

feat(ourlogs): Alias the remaining SDK-sent attributes #91457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

Conversation

colin-sentry
Copy link
Member

These would show up as red in the search bar because they were using internal aliases

@colin-sentry colin-sentry requested a review from a team as a code owner May 12, 2025 18:20
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 12, 2025
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #91457      +/-   ##
==========================================
+ Coverage   83.80%   87.59%   +3.79%     
==========================================
  Files       10326    10326              
  Lines      586357   586357              
  Branches    22645    22645              
==========================================
+ Hits       491370   513617   +22247     
+ Misses      94544    72297   -22247     
  Partials      443      443              

Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
@colin-sentry colin-sentry merged commit b7db434 into master May 12, 2025
59 checks passed
@colin-sentry colin-sentry deleted the log_aliases branch May 12, 2025 19:11
colin-sentry added a commit that referenced this pull request May 12, 2025
Update frontend renderers to use aliases from
#91457
iamrajjoshi pushed a commit that referenced this pull request May 13, 2025
These would show up as red in the search bar because they were using
internal aliases

---------

Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
iamrajjoshi pushed a commit that referenced this pull request May 13, 2025
Update frontend renderers to use aliases from
#91457
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants