Skip to content

feat(ourlogs): Use aliases in the frontend #91467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025

Conversation

colin-sentry
Copy link
Member

Update frontend renderers to use aliases from #91457

@colin-sentry colin-sentry requested a review from a team as a code owner May 12, 2025 19:03
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 12, 2025
@colin-sentry colin-sentry requested a review from AbhiPrasad May 12, 2025 19:16
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@colin-sentry colin-sentry enabled auto-merge (squash) May 12, 2025 19:19
Copy link

codecov bot commented May 12, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10311 1 10310 9
View the top 1 failed test(s) by shortest run time
useReplayCount getOne & hasOne should return undefined to start, then the count after data is loaded
Stack Traces | 0.091s run time
Error: expect(received).toBe(expected) // Object.is equality

Expected: 5
Received: undefined
    at Object.<anonymous> (.../utils/replayCount/useReplayCount.spec.tsx:57:45)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at listOnTimeout (node:internal/timers:555:9)
    at processTimers (node:internal/timers:529:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@colin-sentry colin-sentry merged commit f79a819 into master May 12, 2025
47 of 49 checks passed
@colin-sentry colin-sentry deleted the ourlogs_frontend_aliases branch May 12, 2025 19:36
iamrajjoshi pushed a commit that referenced this pull request May 13, 2025
Update frontend renderers to use aliases from
#91457
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants