[0.2] Backport renderpass resolve attachments fix #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
changed the title
bors bot
added a commit
that referenced
this pull request
Jun 22, 2019
2853: [0.2] Backport renderpass resolve attachments fix r=kvark a=rukai Backport of https://github.com/gfx-rs/gfx/pull/2813/files I am able to get MSAA working on wgpu only with these changes. Includes a new minor release, is there a process I should be aware of here? The new release is needed because it is impractical to get wgpu to use these changes without a new release because of rendy's dependency on gfx-hal. Simply using a specific git commit fails because rendy and wgpu both need to refer to the same trait from gfx-hal. Fixes #issue PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [x] tested examples with the following backends: vulkan - ~~[ ] `rustfmt` run on changed code~~ Co-authored-by: Rukai <rubickent@gmail.com>
Build succeeded |
|
Looks like a |
|
@msiglreith could you publish it please?
… On Jun 22, 2019, at 16:28, Lucas Kent ***@***.***> wrote:
Looks like a cargo publish needs to be manually run?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
https://crates.io/crates/gfx-backend-vulkan/0.2.3 What we are missing still is a CHANGELOG update (just not to forget...) |
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Jun 24, 2019
28: msaa-line example fixes r=kvark a=rukai This PR fixes the msaa-line example in addition to the fixes in gfx-rs/wgpu#235 If gfx-rs/gfx#2853 is merged first we can remove the crates.io patch. Co-authored-by: Rukai <rubickent@gmail.com>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
28: msaa-line example fixes r=kvark a=rukai This PR fixes the msaa-line example in addition to the fixes in gfx-rs#235 If gfx-rs/gfx#2853 is merged first we can remove the crates.io patch. Co-authored-by: Rukai <rubickent@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of https://github.com/gfx-rs/gfx/pull/2813/files
I am able to get MSAA working on wgpu only with these changes.
Includes a new minor release, is there a process I should be aware of here?
The new release is needed because it is impractical to get wgpu to use these changes without a new release because of rendy's dependency on gfx-hal.
Simply using a specific git commit fails because rendy and wgpu both need to refer to the same trait from gfx-hal.
Fixes #issue
PR checklist:
makesucceeds (on *nix)make reftestssucceeds[ ]rustfmtrun on changed code