Full MSAA handling #235
Merged
Full MSAA handling #235
+171
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Jun 23, 2019
|
@msiglreith it does sound like ATTACHMENT_UNUSED (or some sort of an |
kvark
reviewed
Jun 23, 2019
| let color_attachments = | ||
| unsafe { slice::from_raw_parts(desc.color_attachments, desc.color_attachments_length) }; | ||
| let depth_stencil_attachment = unsafe { desc.depth_stencil_attachment.as_ref() }; | ||
|
|
||
| let sample_count = color_attachments.get(0).map(|at| view_guard[at.attachment].samples).unwrap_or(1); | ||
| assert!(sample_count & samples_count_limit != 0, "Attachment sample_count must be supported by physical device limits"); |
There was a problem hiding this comment.
There was a problem hiding this comment.
oh wow, this is confusing. Filed gfx-rs/gfx#2859
kvark
approved these changes
Jun 23, 2019
| let color_attachments = | ||
| unsafe { slice::from_raw_parts(desc.color_attachments, desc.color_attachments_length) }; | ||
| let depth_stencil_attachment = unsafe { desc.depth_stencil_attachment.as_ref() }; | ||
|
|
||
| let sample_count = color_attachments.get(0).map(|at| view_guard[at.attachment].samples).unwrap_or(1); | ||
| assert!(sample_count & samples_count_limit != 0, "Attachment sample_count must be supported by physical device limits"); |
There was a problem hiding this comment.
oh wow, this is confusing. Filed gfx-rs/gfx#2859
bors bot
added a commit
that referenced
this pull request
Jun 23, 2019
235: Full MSAA handling r=kvark a=rukai These changes fix the msaa-line wgpu example, along with a PR to wgpu-native gfx-rs/wgpu-rs#28 Concerns: * webgpu does not expose a way for users to query limits, how are they supposed to choose a suitable sample_count? * I think `attachment_unused` should be moved into gfx-hal. Where abouts? * Is a sample mask of `:u64 = !0` suitable? Co-authored-by: Rukai <rubickent@gmail.com>
Build succeeded |
yes, a constant might be the easiest way to get started? |
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Jun 24, 2019
28: msaa-line example fixes r=kvark a=rukai This PR fixes the msaa-line example in addition to the fixes in gfx-rs/wgpu#235 If gfx-rs/gfx#2853 is merged first we can remove the crates.io patch. Co-authored-by: Rukai <rubickent@gmail.com>
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
28: msaa-line example fixes r=kvark a=rukai This PR fixes the msaa-line example in addition to the fixes in gfx-rs#235 If gfx-rs/gfx#2853 is merged first we can remove the crates.io patch. Co-authored-by: Rukai <rubickent@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the msaa-line wgpu example, along with a PR to wgpu-native gfx-rs/wgpu-rs#28
Concerns:
attachment_unusedshould be moved into gfx-hal. Where abouts?:u64 = !0suitable?