This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
msaa-line example fixes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
fix-msaa-line-example
branch
from
ff0102e
to
1bd37ed
Compare
kvark
approved these changes
Jun 23, 2019
bors bot
added a commit
to gfx-rs/wgpu
that referenced
this pull request
Jun 23, 2019
235: Full MSAA handling r=kvark a=rukai These changes fix the msaa-line wgpu example, along with a PR to wgpu-native gfx-rs/wgpu-rs#28 Concerns: * webgpu does not expose a way for users to query limits, how are they supposed to choose a suitable sample_count? * I think `attachment_unused` should be moved into gfx-hal. Where abouts? * Is a sample mask of `:u64 = !0` suitable? Co-authored-by: Rukai <rubickent@gmail.com>
rukai
force-pushed
the
fix-msaa-line-example
branch
from
1bd37ed
to
b235c96
Compare
|
Updated the commit, should be good to go. |
bors bot
added a commit
that referenced
this pull request
Jun 24, 2019
28: msaa-line example fixes r=kvark a=rukai This PR fixes the msaa-line example in addition to the fixes in gfx-rs/wgpu#235 If gfx-rs/gfx#2853 is merged first we can remove the crates.io patch. Co-authored-by: Rukai <rubickent@gmail.com>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the msaa-line example in addition to the fixes in gfx-rs/wgpu#235
If gfx-rs/gfx#2853 is merged first we can remove the crates.io patch.