-
Notifications
You must be signed in to change notification settings - Fork 61.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update migrating-oauth-apps-to-github-apps.md to include the 'Delete OAuth App' step #8068
Conversation
These changes are to include the 'Delete OAuth App' step in 'Migrating OAuth Apps to GitHub Apps'
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@123MwanjeMike Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thank you for this addition! I am unable to make suggestions or resolve the merge conflict with main
for this PR. (Possibly changing the settings described in step 7 here would allow this.) Normally, I would make minor changes to reduce busy work for you, but in this case you will need to make the changes.
To get this PR approved, you will need to:
- resolve the merge conflict with
main
- use a relative URL
The final two sections would end up looking something like this:
### Encourage users to revoke access to your OAuth app
As your GitHub App installation base grows, consider encouraging your users to revoke access to the legacy OAuth integration. For more information, see "[Authorizing OAuth Apps](/github/authenticating-to-github/keeping-your-account-and-data-secure/authorizing-oauth-apps)."
### Delete the OAuth App
To avoid abuse of the OAuth App's credentials, consider deleting the OAuth App. This action will also revoke all of the OAuth App's remaining authorizations. For more information, see "[Deleting an OAuth App](/developers/apps/managing-oauth-apps/deleting-an-oauth-app)."
@skedwards88, thank you for your feedback. Sorry I made the changes from a new branch within the docs repository rather than from my fork and thus you could not the changes as desired. |
Proposed changes already merged |
Ok |
These changes are to include the 'Delete OAuth App' step in 'Migrating OAuth Apps to GitHub Apps'
Why:
Closes #8067 (comment), #8640
What's being changed:
Adding the 'Delete OAuth App' step
Check off the following:
Writer impact (This section is for GitHub staff members only):
edited by staff:
Removed square brackets around issue link for automatic issue linking to the PR