Skip to content

update migrating-oauth-apps-to-github-apps.md to include requested ch… #8640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2021
Merged

update migrating-oauth-apps-to-github-apps.md to include requested ch… #8640

merged 3 commits into from
Jul 29, 2021

Conversation

123MwanjeMike
Copy link
Contributor

@123MwanjeMike 123MwanjeMike commented Jul 29, 2021

These changes are to include the 'Delete OAuth App' step in 'Migrating OAuth Apps to GitHub Apps'

Why:

Closes #8067 (comment), #8068

What's being changed:

Adding the 'Delete OAuth App' step

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

edited by staff:
Removed square brackets around issue link for automatic issue linking to the PR

These changes are to include the 'Delete OAuth App' step in 'Migrating OAuth Apps to GitHub Apps'
…anges

This is in relation to the similar PR to github doc that had conflicts not solvable by the github maintainers
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 29, 2021
@skedwards88 skedwards88 changed the base branch from 123MwanjeMike-patch-2 to main July 29, 2021 16:46
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ This looks great! Thanks for taking the time to make this improvement. I'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jul 29, 2021
@skedwards88 skedwards88 enabled auto-merge (squash) July 29, 2021 16:48
@skedwards88 skedwards88 merged commit a5370ff into github:main Jul 29, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@ghost

This comment has been minimized.

@ghost

This comment has been minimized.

@ghost

This comment has been minimized.

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete legacy OAuth App after migrating to Github Apps
4 participants