-
Couldn't load subscription status.
- Fork 1.3k
[server] Use image-builder from workspace cluster (feature flag: "movedImageBuilder") #11103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/werft run 👍 started the job as gitpod-build-gpl-imgbldr.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not test, only reviewed one file for which I am code owner and that one LGTM. 🙏
Description
This is part II of a translation from Chris' PR. To be able to move forward with this, it got split into two:
servertalk tows-managerfor image builds (this PR) (feature flag: "movedImageBuilder")The idea is to get both merged, and be able to test and iterate independently.
/cc @kylos101
Note 1: All formatting should be in commit 1, so it's sufficient to review commit 2 alone.
Note 2: Commit 3 + 4 do not strictly belong into this PR but I left them here because they ease testing. 🧘
Related Issue(s)
Fixes #9248
Context: #9337
How to test
imgbldrand project (e.g. on this test repo) (theimgbldrtriggers feature flagsmovedImageBuilderanddeprecateOldImageLogsMechanism, cmp. here)serverlogs for the lineimage-builder in workspace clusterto validate you actually used the new mechanismRelease Notes
Documentation
Werft options: