Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Use image-builder from workspace cluster (feature flag: "movedImageBuilder") #11103

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 4, 2022

Description

This is part II of a translation from Chris' PR. To be able to move forward with this, it got split into two:

  1. The deprecation of the old log retrieval mechanism in this PR (feature flag: "deprecateOldImageLogsMechanism")
  2. Make server talk to ws-manager for image builds (this PR) (feature flag: "movedImageBuilder")

The idea is to get both merged, and be able to test and iterate independently.

/cc @kylos101

Note 1: All formatting should be in commit 1, so it's sufficient to review commit 2 alone.

Note 2: Commit 3 + 4 do not strictly belong into this PR but I left them here because they ease testing. 🧘

Related Issue(s)

Fixes #9248

Context: #9337

How to test

  • preview env: create a team with a name containing imgbldr and project (e.g. on this test repo) (the imgbldr triggers feature flags movedImageBuilder and deprecateOldImageLogsMechanism, cmp. here)
  • push a commit, for instance to this branch
  • open a workspace on that branch
  • observe that workspace start and the streaming of image build logs works as expected
  • check server logs for the line image-builder in workspace cluster to validate you actually used the new mechanism

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@geropl
Copy link
Member Author

geropl commented Jul 5, 2022

/werft run

👍 started the job as gitpod-build-gpl-imgbldr.5
(with .werft/ from main)

@geropl geropl marked this pull request as ready for review July 5, 2022 13:17
@geropl geropl requested a review from a team July 5, 2022 13:17
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 5, 2022
Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test, only reviewed one file for which I am code owner and that one LGTM. 🙏

@geropl geropl requested a review from easyCZ July 8, 2022 11:59
@roboquat roboquat merged commit cceb62f into main Jul 12, 2022
@roboquat roboquat deleted the gpl/imgbldr branch July 12, 2022 09:11
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make server talk to image-builder in workspace cluster
6 participants