-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Use image-builder from workspace cluster (feature flag: "movedImageBuilder") #11103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
/werft run 👍 started the job as gitpod-build-gpl-imgbldr.5 |
sagor999
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not test, only reviewed one file for which I am code owner and that one LGTM. 🙏
easyCZ
reviewed
Jul 8, 2022
components/server/src/workspace/workspace-cluster-imagebuilder-client-provider.ts
Show resolved
Hide resolved
easyCZ
approved these changes
Jul 11, 2022
aledbf
approved these changes
Jul 12, 2022
csweichel
approved these changes
Jul 12, 2022
roboquat
added
deployed: webapp
Meta team change is running in production
deployed
Change is completely running in production
labels
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: webapp
Meta team change is running in production
deployed
Change is completely running in production
release-note-none
size/XL
team: webapp
Issue belongs to the WebApp team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part II of a translation from Chris' PR. To be able to move forward with this, it got split into two:
server
talk tows-manager
for image builds (this PR) (feature flag: "movedImageBuilder")The idea is to get both merged, and be able to test and iterate independently.
/cc @kylos101
Note 1: All formatting should be in commit 1, so it's sufficient to review commit 2 alone.
Note 2: Commit 3 + 4 do not strictly belong into this PR but I left them here because they ease testing. 🧘
Related Issue(s)
Fixes #9248
Context: #9337
How to test
imgbldr
and project (e.g. on this test repo) (theimgbldr
triggers feature flagsmovedImageBuilder
anddeprecateOldImageLogsMechanism
, cmp. here)server
logs for the lineimage-builder in workspace cluster
to validate you actually used the new mechanismRelease Notes
Documentation
Werft options: