[server] Use image-builder from workspace cluster #9337

csweichel · 2022-04-14T16:19:04Z

Description

This PR makes server use the image builder from workspace cluster.

**Note: ** merge and deploy this only once #9335 is merged, deployed and running.

Related Issue(s)

Fixes #9248

How to test

Start a workspace which requires an image-build

Release Notes

Use image-builder from workspace cluster

/werft run with-vm=true

csweichel · 2022-04-21T09:09:11Z

/werft run with-clean-slate

👍 started the job as gitpod-build-cw-imgbldr-mv-ii.3

kylos101 · 2022-04-23T22:27:57Z

Hi 👋 ,

@csweichel #9335 is deployed. 👍 🙌

@geropl , do we have a governed workspace cluster in staging that is separate from webapp, so we can test similar to prod? If not, we may be able to do with am ephemeral cluster, or workspace-preview.

What scenarios do we have to test?

Test with an explicit image build, similar to gitpod.io/#imagebuild/ (it should image build)
Test a prebuild that needs an image build first (it should image build, before doing prebuild)
Test a fresh repo with a custom dockerfile by starting a regular workspace (it should image build)
Am I missing any other scenarios? 🤔

@aledbf is there anything we need to prepare for, that you can think of, that we should add here?

geropl · 2022-04-25T07:23:54Z

do we have a governed workspace cluster in staging that is separate from webapp, so we can test similar to prod?

We don't have separate workspace clusters, for have EU/US as "full" installations, with the ws-manager being dynamically registered. So we should be able to test just like in prod. 👍

Will review here today.

geropl · 2022-04-26T07:08:11Z

components/server/src/workspace/gitpod-server-impl.ts

-            ctx.span?.setTag("workspace.imageBuild.logs.fallback", true);
-            await this.deprecatedDoWatchWorkspaceImageBuildLogs(ctx, logCtx, workspace);
-            return;
+            log.error(logCtx, "cannot watch imagebuild logs for workspaceId: no image build info available");


geropl · 2022-04-26T07:08:56Z

BTW: reviewed yesterday, and code looks good! 🙏

Now waiting for a preview to test and play around with.

geropl · 2022-04-26T07:09:16Z

/werft run

👍 started the job as gitpod-build-cw-imgbldr-mv-ii.6
(with .werft/ from main)

geropl · 2022-04-27T09:28:09Z

@csweichel Can we move forward with this, or is it blocked somehow? 🤔
Also, happy to assign someone from WebApp for rebasing/testing etc. if that helps. 🙏

csweichel · 2022-05-10T17:39:18Z

Taking this back to "ready for review" because the PR is indeed ready for review.
With the ws45 clusters being rolled out tomorrow, webapp could deploy this change to prod (e.g. on Thursday).

/hold

sagor999 · 2022-05-20T00:18:56Z

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-cw-imgbldr-mv-ii.17
(with .werft/ from main)

sagor999

lgtm, except for one minor typo, but approving with hold to address that fix.
/hold

Tested in preview env using @jankeromnes two test repos and everything worked as expected.

sagor999 · 2022-05-20T00:49:39Z

components/ws-manager-api/typescript/src/client-provider.ts

@@ -92,14 +92,14 @@ export class WorkspaceManagerClientProvider implements Disposable {
        let client = this.connectionCache.get(name);
        if (!client) {
            const info = await getConnectionInfo();
-            client = this.createClient(info, grpcOptions);
+            client = client = this.createConnection(WorkspaceManagerClient, info, grpcOptions);


@csweichel this is still not addressed.

sagor999 · 2022-05-20T16:56:25Z

/unhold

sagor999 · 2022-05-24T17:05:01Z

/hold
we are holding this until we deploy XL cluster change. And after that we can try to get this PR reviewed and pushed.

aledbf · 2022-06-03T14:37:31Z

we are holding this until we deploy XL cluster change. And after that we can try to get this PR reviewed and pushed.

We have that now in gen46. What's missing?

csweichel · 2022-06-03T14:40:40Z

We need to investigate if the new image builder log path is being used. I.e. the path where image builder reports the log location and server consumes it the same way we do for prebuilds.

AlexTugarev · 2022-06-15T12:21:10Z

What's the state of this issue?

We did various improvements and bug fixes around the "Prebuild in Progress" view in #10361, but without a refresh on image build logs mentioned previously, it's overshadowed by the lack of logs. From UX perspective the view remains broken, as no one will know how long to wait for the results if the logs aren't served.

easyCZ · 2022-06-27T07:41:15Z

I'm moving this into draft as currently it is unclear what remains to do on this PR. Feel free to bring back into review if this is in a reviewable (and mergeable) state.

geropl · 2022-06-30T13:09:12Z

I'm moving this into draft as currently it is unclear what remains to do on this PR. Feel free to bring back into review if this is in a reviewable (and mergeable) state.

@easyCZ 👍 for moving into draft.

FYI, @kylos101 and I agreed that the next step is two things:

try if having workspaces run in workspace clusters actually does work (Team Workspace)
try and test if log streaming works from workspaces clusters (Team WebApp, Remove deprecated image build log mechanism #11024)

ℹ️ The logs-PR contains some of the changes from this branch, so I will rebase it once those one hit main.

geropl · 2022-07-04T06:42:49Z

To move forward I split up both aspects of this PR and put them behind feature flags. The 2nd PR is here: #11103 .

stale · 2022-07-30T17:56:15Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sagor999 · 2022-08-04T00:54:03Z

@csweichel @kylos101 what would you like to do with this PR?

aledbf · 2023-03-29T18:44:57Z

Closing. Done.

roboquat added release-note do-not-merge/work-in-progress size/XL labels Apr 14, 2022

csweichel mentioned this pull request Apr 14, 2022

Move image-builder to the workspace cluster #9249

Closed

csweichel force-pushed the cw/imgbldr-mv-ii branch from a2daa49 to 20caf33 Compare April 14, 2022 16:23

roboquat added size/XXL and removed size/XL labels Apr 14, 2022

csweichel changed the base branch from main to cw/imgbldr-mv-i April 14, 2022 16:23

roboquat added size/XL and removed size/XXL labels Apr 14, 2022

csweichel force-pushed the cw/imgbldr-mv-i branch 2 times, most recently from 4f5fb05 to b6906d7 Compare April 19, 2022 13:33

Base automatically changed from cw/imgbldr-mv-i to main April 19, 2022 16:17

roboquat added size/XXL and removed size/XL labels Apr 19, 2022

csweichel force-pushed the cw/imgbldr-mv-ii branch from 20caf33 to 4d34259 Compare April 19, 2022 17:12

roboquat added size/XL and removed size/XXL labels Apr 19, 2022

csweichel force-pushed the cw/imgbldr-mv-ii branch from 4d34259 to b4175c6 Compare April 25, 2022 07:35

roboquat added size/L and removed size/XL labels Apr 25, 2022

csweichel force-pushed the cw/imgbldr-mv-ii branch from b4175c6 to e681a76 Compare April 25, 2022 08:03

geropl reviewed Apr 26, 2022

View reviewed changes

csweichel force-pushed the cw/imgbldr-mv-ii branch from e681a76 to 6e37dca Compare April 28, 2022 17:36

csweichel marked this pull request as ready for review May 10, 2022 17:39

roboquat removed the do-not-merge/work-in-progress label May 10, 2022

sagor999 approved these changes May 20, 2022

View reviewed changes

[server] Remove deprecated image build log mechanism

c1508ba

csweichel force-pushed the cw/imgbldr-mv-ii branch from 964929b to c1508ba Compare May 20, 2022 07:45

roboquat removed the do-not-merge/hold label May 20, 2022

roboquat added the do-not-merge/hold label May 24, 2022

princerachit mentioned this pull request May 25, 2022

[image-builder-bob] Prioritize using additional auth #10235

Closed

jankeromnes removed their assignment Jun 8, 2022

easyCZ marked this pull request as draft June 27, 2022 07:41

roboquat added the do-not-merge/work-in-progress label Jun 27, 2022

geropl mentioned this pull request Jun 30, 2022

Remove deprecated image build log mechanism #11024

Closed

geropl mentioned this pull request Jul 4, 2022

[server] Use image-builder from workspace cluster (feature flag: "movedImageBuilder") #11103

Merged

1 task

stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jul 30, 2022

kylos101 added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Aug 1, 2022

aledbf closed this Mar 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[server] Use image-builder from workspace cluster #9337

[server] Use image-builder from workspace cluster #9337

csweichel commented Apr 14, 2022 •

edited by geropl

Loading

csweichel commented Apr 21, 2022 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 commented Apr 23, 2022

geropl commented Apr 25, 2022 •

edited

Loading

geropl Apr 26, 2022

geropl commented Apr 26, 2022

geropl commented Apr 26, 2022 •

edited by werft-gitpod-dev-com bot

Loading

geropl commented Apr 27, 2022

csweichel commented May 10, 2022

sagor999 commented May 20, 2022 •

edited by werft-gitpod-dev-com bot

Loading

sagor999 left a comment

sagor999 May 20, 2022

sagor999 commented May 20, 2022

sagor999 commented May 24, 2022

aledbf commented Jun 3, 2022

csweichel commented Jun 3, 2022

AlexTugarev commented Jun 15, 2022

easyCZ commented Jun 27, 2022

geropl commented Jun 30, 2022

geropl commented Jul 4, 2022

stale bot commented Jul 30, 2022

sagor999 commented Aug 4, 2022 •

edited

Loading

aledbf commented Mar 29, 2023

[server] Use image-builder from workspace cluster #9337

[server] Use image-builder from workspace cluster #9337

Conversation

csweichel commented Apr 14, 2022 • edited by geropl Loading

Description

Related Issue(s)

How to test

Release Notes

csweichel commented Apr 21, 2022 • edited by werft-gitpod-dev-com bot Loading

kylos101 commented Apr 23, 2022

geropl commented Apr 25, 2022 • edited Loading

geropl Apr 26, 2022

Choose a reason for hiding this comment

geropl commented Apr 26, 2022

geropl commented Apr 26, 2022 • edited by werft-gitpod-dev-com bot Loading

geropl commented Apr 27, 2022

csweichel commented May 10, 2022

sagor999 commented May 20, 2022 • edited by werft-gitpod-dev-com bot Loading

sagor999 left a comment

Choose a reason for hiding this comment

sagor999 May 20, 2022

Choose a reason for hiding this comment

sagor999 commented May 20, 2022

sagor999 commented May 24, 2022

aledbf commented Jun 3, 2022

csweichel commented Jun 3, 2022

AlexTugarev commented Jun 15, 2022

easyCZ commented Jun 27, 2022

geropl commented Jun 30, 2022

geropl commented Jul 4, 2022

stale bot commented Jul 30, 2022

sagor999 commented Aug 4, 2022 • edited Loading

aledbf commented Mar 29, 2023

csweichel commented Apr 14, 2022 •

edited by geropl

Loading

csweichel commented Apr 21, 2022 •

edited by werft-gitpod-dev-com bot

Loading

geropl commented Apr 25, 2022 •

edited

Loading

geropl commented Apr 26, 2022 •

edited by werft-gitpod-dev-com bot

Loading

sagor999 commented May 20, 2022 •

edited by werft-gitpod-dev-com bot

Loading

sagor999 commented Aug 4, 2022 •

edited

Loading