Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Project DB config feature #12873

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Remove deprecated Project DB config feature #12873

merged 1 commit into from
Sep 13, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Sep 12, 2022

Description

The Project DB config is now deprecated and unused. This PR removes it.

  • The "Project Configurator" feature was first introduced as part of the New Project flow
  • Then it was removed from the New Project flow, and kept as an extra feature in the Project Settings menu
  • Then it was superseded by auto-generated .gitpod.ymls in every workspace: Always Infer .gitpod.yml #6921
  • Additionally, we automatically reject webhooks when there is no explicit .gitpod.yml file in the repo, so Project DB configs were actually never used for regular prebuilds:
    shouldPrebuild(config: WorkspaceConfig | undefined): boolean {
    if (!config || !config._origin || config._origin !== "repo") {
    // we demand an explicit gitpod config
    return false;
    }

Related Issue(s)

Fixes #9102

How to test

  1. Adding new Projects should still work
  2. Prebuilds should still work
  3. The "Configuration" feature/tab should no longer exist in Project Settings

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Sep 12, 2022

/werft run

👍 started the job as gitpod-build-jx-rm-configure.1
(with .werft/ from main)

@jankeromnes jankeromnes marked this pull request as ready for review September 12, 2022 15:39
@jankeromnes jankeromnes requested a review from a team September 12, 2022 15:39
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 12, 2022
@roboquat roboquat merged commit 7a23e97 into main Sep 13, 2022
@roboquat roboquat deleted the jx/rm-configure branch September 13, 2022 05:50
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XXL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate gitpod.yml config stored in the DB
3 participants