[dashboard] Remove Prebuild logs and button from Project Settings #8831

easyCZ · 2022-03-15T22:31:24Z

Description

Removes the following:

Prebuild log view from Project Configuration
Ability to trigger prebuilds from Project configuration. See Before & After screenshots below.

Old:

New:

Related Issue(s)

How to test

Open up preview environment
Create a project
Navigate to project settings
Observe no toggle to run prebuilds or a log viewer

Release Notes

Remove Prebuild action and log view from Project Settings view

/werft with-clean-slate-deployment
/hold

easyCZ · 2022-03-16T15:54:58Z

@jldec Let me know if this matches your expectation for the prebuild removal.

stale · 2022-03-26T20:24:41Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

AlexTugarev

~~Works as advertised!~~

Just confused with another PR of yours. This is next.

components/dashboard/src/projects/ConfigureProject.tsx

AlexTugarev · 2022-03-29T09:01:15Z

/werft run

👍 started the job as gitpod-build-mp-pb-status-proj-conf.9

easyCZ · 2022-03-29T12:02:49Z

@gtsiolis @jldec I've now pushed a fix for the issue you've discovered, thanks! I'm moving this back into review.

The behaviour is now as follows when there is no gitpod.yml in the repo:

Edit the config
Click New Workspace which saves the config.

This doesn't feel like the most intuitive, but matches the original behaviour (which was Run prebuild rather than New Workspace).
We could explicitly introduce a button to save the config, which may be nicer.

gtsiolis · 2022-03-29T12:25:31Z

Thanks, @easyCZ! Works as before now.

This doesn't feel like the most intuitive, but matches the original behaviour

Agree, this is also a bit confusing as we auto-save but not fast enough to include all latest changes in the updated and injected .gitpod.yml file. Maybe a subtle auto-save visual feedback on the editor along with a configuration validation action could help. 💭

issue: One seemingly important issue but probably not worth blocking merging this is that now when the configuration is invalid we're blocking the users from starting a new workspace without any error or visual feedback as we did with when having the ability to trigger a prebuild, see screenshot below. ❗

(BEFORE) Invalid configuration (Run Prebuild)	(AFTER) Invalid configuration (New Workspace)

jldec · 2022-03-29T14:43:01Z

@easyCZ, I expected the prebuild from the config to show up in the prebuild log view inside the start workspace page.
Is this not happening for some reason? I now see the prebuild and command task running inside the IDE.

we auto-save but not fast enough to include all latest changes in the updated and injected .gitpod.yml file.

If @gtsiolis is right about ☝️ then the autosave is not working reliably - pending changes should be saved before the button click takes you out of the page.

I don't think we need a separate save button, but it would be nice indicate in the UI that the save has happened. I can live without this enhancement for this PR. See #6724

Bad gitpod.yml errors should also show up on the start workspace page e.g.

easyCZ · 2022-03-29T14:58:01Z

I'm digging into this some more just now. It looks like for this behaviour to remain the same, the following must happen in order:

Click start workspace
The current gitpod.yml config is stored on the server
A prebuild is triggered -> this then uses the previously saved gitpod.yml
Redirect to the context URL to start a new workspace. Because there was a prebuild in step 3, it will show the prebuild steps.

In the current implementation, we're not triggering the prebuild and as such the workspace start drops you into the IDE with the before and init tasks being run in the current terminal.

The fix is to re-add the trigger of a prebuild when you're starting a workspace. However, now with the prebuild view gone, we don't have a place to report progress. How do you want to handle this @jldec?

easyCZ · 2022-04-04T13:02:07Z

I've now updated this PR with the following:

Triggering a new workspace saves the config and starts a prebuild, once the prebuild request is accepted, we redirect to the workspace detail page where the prebuild logs will show
The button becomes disabled once clicked and shows the status - "Saving configration..." or "Starting a prebuild"

Once staging with new images becomes usable again, I'll put this back into review.

easyCZ · 2022-04-04T14:37:35Z

/werft run

👍 started the job as gitpod-build-mp-pb-status-proj-conf.20

easyCZ · 2022-04-04T14:57:15Z

jldec

LGTM
Thanks for starting the cleanup
I think this is good for now - I expect we will remove this dashboard editor feature entirely when we deprecate the config in DB with #9102

/hold for other reviews

gtsiolis · 2022-04-05T11:52:13Z

Looking at this now! 👀

gtsiolis

UX LGTM.

Left some minor comments below, some of these probably could be best as follow up issues.

Thanks for the ping, @easyCZ! 🏓

gtsiolis · 2022-04-05T11:55:51Z

components/dashboard/src/projects/ConfigureProject.tsx

-    useEffect(() => {
-        document.title = "Configure Project — Gitpod";
-    }, []);
+                setProgressMessage("Starting a new prebuild...");


question: Is there a limitation that does not allow us to simply redirect to the workspace start page which automatically surfaces when a prebuild is running?

In my testing, starting a prebuild was required to actually use the new config. It wouldn't get picked up after the save without the prebuild. However, this may be a red-herring. I need to dig into the config & prebuild flow a bit more to understand why this is, and if in fact this is the case.

Will investigate!

I've attempted to remove the prebuild step but the saved configuration is not reflected in the workspace. I will continue to investigate but in the meantime, this PR is functionally complete and will land.

Sounds good! Thanks for taking a closer look, @easyCZ!

gtsiolis · 2022-04-05T11:57:23Z

components/dashboard/src/projects/ConfigureProject.tsx

-    useEffect(() => {
-        document.title = "Configure Project — Gitpod";
-    }, []);
+                setProgressMessage("Starting a new prebuild...");


issue: This could be minor but starting a prebuild is not always the case, right? When the default skeleton configuration is generated for a new project, a prebuild will not actually start, no?

tasks: - init: | echo 'TODO: build project' command: | echo 'TODO: start app'

Good point! Related to the other point raised around:

question: Is there a limitation that does not allow us to simply redirect to the workspace start page which automatically surfaces when a prebuild is running?

Will investigate!

components/dashboard/src/projects/Prebuilds.tsx

easyCZ · 2022-04-05T14:03:36Z

/unhold

roboquat added do-not-merge/hold do-not-merge/work-in-progress do-not-merge/release-note-label-needed size/M size/L and removed size/M labels Mar 15, 2022

easyCZ changed the title ~~WIP: Use normalized prebuild status in ProjectConfiguration~~ WIP: [dashboard] Remove Prebuild logs and button from Project Settings Mar 16, 2022

easyCZ changed the base branch from mp/pb-status to main March 16, 2022 14:53

easyCZ force-pushed the mp/pb-status-proj-conf branch 4 times, most recently from 313f48b to 9261a39 Compare March 16, 2022 14:57

roboquat added release-note and removed do-not-merge/release-note-label-needed labels Mar 16, 2022

easyCZ force-pushed the mp/pb-status-proj-conf branch from 9261a39 to ca8a204 Compare March 16, 2022 15:22

easyCZ changed the title ~~WIP: [dashboard] Remove Prebuild logs and button from Project Settings~~ [dashboard] Remove Prebuild logs and button from Project Settings Mar 16, 2022

easyCZ marked this pull request as ready for review March 16, 2022 15:35

easyCZ requested a review from a team March 16, 2022 15:35

github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 16, 2022

roboquat removed the do-not-merge/work-in-progress label Mar 16, 2022

stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 26, 2022

easyCZ removed the meta: stale This issue/PR is stale and will be closed soon label Mar 26, 2022

AlexTugarev previously approved these changes Mar 29, 2022

View reviewed changes

AlexTugarev self-requested a review March 29, 2022 08:59

AlexTugarev reviewed Mar 29, 2022

View reviewed changes

components/dashboard/src/projects/ConfigureProject.tsx Outdated Show resolved Hide resolved

easyCZ dismissed AlexTugarev’s stale review via 52ff8b9 March 29, 2022 09:28

easyCZ force-pushed the mp/pb-status-proj-conf branch from ca8a204 to 52ff8b9 Compare March 29, 2022 09:28

roboquat added the do-not-merge/work-in-progress label Mar 29, 2022

easyCZ dismissed gtsiolis’s stale review via 79d05a4 March 29, 2022 12:00

easyCZ force-pushed the mp/pb-status-proj-conf branch from 68481c9 to 79d05a4 Compare March 29, 2022 12:00

easyCZ marked this pull request as ready for review March 29, 2022 12:02

roboquat removed the do-not-merge/work-in-progress label Mar 29, 2022

gtsiolis mentioned this pull request Mar 29, 2022

Alert component for errors and notifications #8933

Open

easyCZ mentioned this pull request Apr 4, 2022

[dashboard] Show prebuild status based on prebuild workspace record #8805

Merged

1 task

easyCZ force-pushed the mp/pb-status-proj-conf branch 2 times, most recently from 41e8b26 to 61b07a9 Compare April 4, 2022 12:39

Remove Prebuild logs from ProjectConfiguration view

00972cb

easyCZ force-pushed the mp/pb-status-proj-conf branch from 61b07a9 to 00972cb Compare April 4, 2022 14:36

easyCZ requested review from gtsiolis and a team April 4, 2022 20:21

jldec approved these changes Apr 4, 2022

View reviewed changes

gtsiolis approved these changes Apr 5, 2022

View reviewed changes

easyCZ mentioned this pull request Apr 5, 2022

Use the same prebuild view for Workspace start as for Prebuild Details #9132

Closed

roboquat removed the do-not-merge/hold label Apr 5, 2022

roboquat merged commit 0c20837 into main Apr 5, 2022

roboquat deleted the mp/pb-status-proj-conf branch April 5, 2022 14:04

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dashboard] Remove Prebuild logs and button from Project Settings #8831

[dashboard] Remove Prebuild logs and button from Project Settings #8831

easyCZ commented Mar 15, 2022 •

edited

Loading

easyCZ commented Mar 16, 2022

stale bot commented Mar 26, 2022

AlexTugarev left a comment •

edited

Loading

AlexTugarev commented Mar 29, 2022 •

edited by werft-gitpod-dev-com bot

Loading

easyCZ commented Mar 29, 2022 •

edited

Loading

gtsiolis commented Mar 29, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jldec commented Mar 29, 2022 •

edited by werft-gitpod-dev-com bot

Loading

easyCZ commented Mar 29, 2022

easyCZ commented Apr 4, 2022

easyCZ commented Apr 4, 2022 •

edited by werft-gitpod-dev-com bot

Loading

easyCZ commented Apr 4, 2022

jldec left a comment

gtsiolis commented Apr 5, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment

gtsiolis Apr 5, 2022

easyCZ Apr 5, 2022

easyCZ Apr 5, 2022

gtsiolis Apr 5, 2022

gtsiolis Apr 5, 2022

easyCZ Apr 5, 2022

easyCZ commented Apr 5, 2022

[dashboard] Remove Prebuild logs and button from Project Settings #8831

[dashboard] Remove Prebuild logs and button from Project Settings #8831

Conversation

easyCZ commented Mar 15, 2022 • edited Loading

Description

Old:

New:

Related Issue(s)

How to test

Release Notes

easyCZ commented Mar 16, 2022

stale bot commented Mar 26, 2022

AlexTugarev left a comment • edited Loading

Choose a reason for hiding this comment

AlexTugarev commented Mar 29, 2022 • edited by werft-gitpod-dev-com bot Loading

easyCZ commented Mar 29, 2022 • edited Loading

gtsiolis commented Mar 29, 2022 • edited by werft-gitpod-dev-com bot Loading

jldec commented Mar 29, 2022 • edited by werft-gitpod-dev-com bot Loading

easyCZ commented Mar 29, 2022

easyCZ commented Apr 4, 2022

easyCZ commented Apr 4, 2022 • edited by werft-gitpod-dev-com bot Loading

easyCZ commented Apr 4, 2022

jldec left a comment

Choose a reason for hiding this comment

gtsiolis commented Apr 5, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment

Choose a reason for hiding this comment

gtsiolis Apr 5, 2022

Choose a reason for hiding this comment

easyCZ Apr 5, 2022

Choose a reason for hiding this comment

easyCZ Apr 5, 2022

Choose a reason for hiding this comment

gtsiolis Apr 5, 2022

Choose a reason for hiding this comment

gtsiolis Apr 5, 2022

Choose a reason for hiding this comment

easyCZ Apr 5, 2022

Choose a reason for hiding this comment

easyCZ commented Apr 5, 2022

easyCZ commented Mar 15, 2022 •

edited

Loading

AlexTugarev left a comment •

edited

Loading

AlexTugarev commented Mar 29, 2022 •

edited by werft-gitpod-dev-com bot

Loading

easyCZ commented Mar 29, 2022 •

edited

Loading

gtsiolis commented Mar 29, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jldec commented Mar 29, 2022 •

edited by werft-gitpod-dev-com bot

Loading

easyCZ commented Apr 4, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Apr 5, 2022 •

edited by werft-gitpod-dev-com bot

Loading