Fix multiple collector issues; fixes #7709, #7787 and #7790 #7748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-anne
force-pushed
the
9.5/fix-mailcollector-encoding
branch
2 times, most recently
from
88a8d2a to
761378f
Compare
|
Looking at debug in test, I do not know if there is a decoding issue or if it is just CI environment that is not able to correctly render some chars. |
cedric-anne
force-pushed
the
9.5/fix-mailcollector-encoding
branch
from
72a7c74 to
17bc1ec
Compare
|
Debug output into CIrcleCI show that encoding is now correct. |
orthagh
approved these changes
Jul 23, 2020
cedric-anne
force-pushed
the
9.5/fix-mailcollector-encoding
branch
from
17bc1ec to
8315bc2
Compare
cedric-anne
changed the title
cedric-anne
changed the title
orthagh
approved these changes
Jul 30, 2020
trasher
approved these changes
Aug 4, 2020
This was referenced Aug 24, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7709, some fixes were made on GLPI 9.4 in #4844 to fix encoding issues. I tried to reproduced the same behavior.
I also refactored a little the test suite to make it easier to update.