Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project page columns' height to be set by contents rather than viewports #31666

Closed
SimonPistache opened this issue Jul 20, 2024 · 3 comments
Closed
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone

Comments

@SimonPistache
Copy link
Contributor

SimonPistache commented Jul 20, 2024

Feature Description

Currently, the Project page contains columns whose height are defined by either a minimal value or a fraction of the available viewport.
Capture d’écran 2024-07-21 à 00 58 18

If this looks pleasing on large screens — on smaller screens (using a Macbook 14"), browsing 30+ issues is not ideal:

  • Its harder to have an overview of the kanban board
  • Peeking or Seeking issues is more complexe
  • Browsing issues require a lot of individual scroll actions
  • Scrollbars eat up each column available surface, especially for user on Windows 10 and below and some Linux Distros, some browsers or specific (accessibility) settings
  • Searching issues (via browser text search — a.k.a Ctrl+F) doesn't correctly scroll down to the highlighted match (tested on Firefox)
Capture d’écran 2024-07-21 à 01 05 35

I propose to instead set the Project board to take as much space a needed by its content:

  • Can make the webpage veeeeeeeery long
  • 1 global scrollbar
  • More effective peeking for issues
  • Scroll to the match when text searching
  • Access to the page footer is longer
  • 1 line of code to implement?
Capture d’écran 2024-07-21 à 01 17 00

It's easy to test an implementation by deleting the height: calc(100vh - 450px); rule from .project-column selector in index.css §9711:

.project-column {
  background-color:var(--color-project-board-bg)!important;
  border:1px solid var(--color-secondary)!important;
  margin:0 .5rem!important;
  padding:.5rem!important;
  width:320px;
  height:fit-content;
  /*height:calc(100vh - 450px);*/
  min-height:60vh;
  flex:0 0 auto;
  overflow:visible;
  display:flex;
  flex-direction:column;
  cursor:default
}

What do you think? Could that help make the Kanban board easier and quicker to use?

Screenshots

Jira board 2024
Jira board 2020
Github

@SimonPistache SimonPistache added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jul 20, 2024
@SimonPistache
Copy link
Contributor Author

I realised there are room for improvement in my suggestion…

The issue is the columns are uneven:
Capture d’écran 2024-07-21 à 13 06 44


As the columns are in a flexbox container, it's easy to set them to have all the same size of the biggest one:
Capture d’écran 2024-07-21 à 13 14 12

.board {
  /* […] */
  align-items: stretch;
}

.project-column {
  /* […] */
  height: initial; /* Or remove the attribute entirely */
}

@lunny
Copy link
Member

lunny commented Jul 29, 2024

Looks better than before.

@SimonPistache
Copy link
Contributor Author

I'll do a PR then

SimonPistache added a commit to SimonPistache/gitea that referenced this issue Jul 29, 2024
In Projects, columns heights are defined by the sum of all contents height of the biggest column, rather than a fraction of the viewport height. It default to 60vh when there is no cards to display.
SimonPistache added a commit to SimonPistache/gitea that referenced this issue Aug 6, 2024
As demonstrated in go-gitea#31726 (comment), an horizontal scrollbar can appears while dragging a card to a column from the right side, as the ghost card is animated to fit in. Force hidding the scrollbars using overflow:clip.
SimonPistache added a commit to SimonPistache/gitea that referenced this issue Aug 6, 2024
A vertical scrollbar can appears while dragging a card-out, when the column height is higher than the heght-viewport and the board is being reduced (quicker than its contents). Force hidding the scrollbars using overflow:clip.
SimonPistache added a commit to SimonPistache/gitea that referenced this issue Aug 6, 2024
@lunny lunny added this to the 1.23.0 milestone Sep 16, 2024
@lunny lunny closed this as completed in 859be09 Sep 16, 2024
zjjhot added a commit to zjjhot/gitea that referenced this issue Sep 18, 2024
* giteaofficial/main:
  Add missing comment reply handling (go-gitea#32050)
  Fix CI (go-gitea#32062)
  Lazy load avatar images (go-gitea#32051)
  Included tag search capabilities (go-gitea#32045)
  Do not escape relative path in RPM primary index (go-gitea#32038)
  feat(go-gitea#31666): Set the columns height to hug all its contents (go-gitea#31726)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Use a common message template instead of a special one (go-gitea#31878)
  Check if the `due_date` is nil when editing issues (go-gitea#32035)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants