Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a common message template instead of a special one #31878

Merged
merged 7 commits into from
Sep 14, 2024
Merged

Use a common message template instead of a special one #31878

merged 7 commits into from
Sep 14, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 19, 2024 •
edited
Loading

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 19, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2024
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code labels Aug 19, 2024
@lunny lunny mentioned this pull request Aug 19, 2024
Merged
lafriks
lafriks previously requested changes Aug 19, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 19, 2024
lafriks

This comment was marked as duplicate.

Sign in to view

@lafriks lafriks self-requested a review August 21, 2024 12:48
@lafriks lafriks dismissed their stale review August 21, 2024 12:48

unblocking

@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Aug 21, 2024
@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 26, 2024
@wxiaoguang
Copy link
Contributor

Well, @go-gitea/technical-oversight-committee seldom fulfill their responsibilities.

@wolfogre
Copy link
Member

I agree with wxiaoguang that there's no difference between a function name or any other word that could let people locate the line of code, since Gitea is an open-source project.

And I prefer 6dfaa72; a109192 doesn't look good to me, it seems like a tiring and confusing job for developers. I have to think of another word that is "safer" than the function name for non-admin users. I have no idea how to do that. Does this look good?

		if ctx.IsSigned && ctx.Doer.IsAdmin {
			ctx.Flash.Error(ctx.Tr("internal_error_skipped", "FindTagsByCommitIDs"))
		} else {
			ctx.Flash.Error(ctx.Tr("internal_error_skipped", "Find tags by commit IDs"))
		}

If yes, why is Find tags by commit IDs safer than FindTagsByCommitIDs? If no, what is the judgment standard?

@lunny
Copy link
Member Author

lunny commented Sep 13, 2024

Reverted to the previous solution. Please review it again. @wxiaoguang @wolfogre @techknowlogick

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 14, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) September 14, 2024 16:42
@techknowlogick techknowlogick merged commit 3febcaa into go-gitea:main Sep 14, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Sep 14, 2024
@lunny lunny deleted the lunny/load_fail_message branch September 14, 2024 17:29
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 18, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5a0b68b 
* giteaofficial/main:
  Add missing comment reply handling (go-gitea#32050)
  Fix CI (go-gitea#32062)
  Lazy load avatar images (go-gitea#32051)
  Included tag search capabilities (go-gitea#32045)
  Do not escape relative path in RPM primary index (go-gitea#32038)
  feat(go-gitea#31666): Set the columns height to hug all its contents (go-gitea#31726)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Use a common message template instead of a special one (go-gitea#31878)
  Check if the `due_date` is nil when editing issues (go-gitea#32035)
@yp05327 yp05327 modified the milestones: 1.24.0, 1.23.0 Sep 19, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@wxiaoguang wxiaoguang wxiaoguang left review comments

@wolfogre wolfogre wolfogre approved these changes

@delvh delvh delvh approved these changes

@lafriks lafriks Awaiting requested review from lafriks

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/translation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
8 participants
@lunny @wxiaoguang @wolfogre @techknowlogick @lafriks @delvh @yp05327 @GiteaBot