-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#31666): Set the columns height to hug all its contents #31726
feat(#31666): Set the columns height to hug all its contents #31726
Conversation
In Projects, columns heights are defined by the sum of all contents height of the biggest column, rather than a fraction of the viewport height. It default to 60vh when there is no cards to display.
I noticed a visual bug while dragging issues around Enregistrement.de.l.ecran.2024-07-29.a.19.58.42.movLooking for a fix |
As demonstrated in go-gitea#31726 (comment), an horizontal scrollbar can appears while dragging a card to a column from the right side, as the ghost card is animated to fit in. Force hidding the scrollbars using overflow:clip.
With the fix: Enregistrement.de.l.ecran.2024-08-06.a.09.20.21.mov |
A vertical scrollbar can appears while dragging a card-out, when the column height is higher than the heght-viewport and the board is being reduced (quicker than its contents). Force hidding the scrollbars using overflow:clip.
I improved the columns behaviours when there is no cards in it. Now, the columns either takes all available height in the viewport, except if it's too small, defaulting to 300px height (and forcing a viewport scrollbar). This makes a newly created Project board attractive to start with. Boards already having cards are not affected by this (Columns takes all available height from the viewport, except if it's too small then it "hug" by its contents.) Enregistrement.de.l.ecran.2024-08-06.a.09.54.37.mov |
There is an issue with this solution: The horizontal scrollbar is way down the board when there is more columns than the viewport can display at once. Idea: <div id="project_board">
<div class="class="board sortable"">
</div>
</div> #project_board {
overflow-x: auto;
overflow-y: hidden;
}
#project_board > .board {
overflow-y: auto;
display: inline-block;
height: 100vh;
white-space: normal;
} This is going back as the idea of the board only overflowing a sub-rectangle of the viewport instead. And that this parent div must have some management of its (own) height. |
* giteaofficial/main: Add missing comment reply handling (go-gitea#32050) Fix CI (go-gitea#32062) Lazy load avatar images (go-gitea#32051) Included tag search capabilities (go-gitea#32045) Do not escape relative path in RPM primary index (go-gitea#32038) feat(go-gitea#31666): Set the columns height to hug all its contents (go-gitea#31726) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Use a common message template instead of a special one (go-gitea#31878) Check if the `due_date` is nil when editing issues (go-gitea#32035)
In Projects, columns heights are defined by the sum of all contents height of the biggest column, rather than a fraction of the viewport height. It default to 60vh when there is no cards to display.
See issue #31666