Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune more downdrop settings, use SVG for labels, improve Repo Topic Edit form #23626

Merged
merged 8 commits into from
Mar 26, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 22, 2023

Although it seems that some different purposes are mixed in this PR, however, they are all related, and can be tested together, so I put them together to save everyone's time.

Diff: +79 −84, everything becomes much better.

Improve the dropdown settings.

Move all fomantic-init related code into our fomantic.js

Fine-tune some dropdown global settings, see the comments.

Also help to fix the first problem in #23625 , cc: @yp05327

The "language" menu has been simplified, and it works with small-height window better.

Use SVG instead of <i class="delete icon">

It's also done by $.fn.dropdown.settings.templates.label , cc: @silverwind

Remove incorrect tabable CSS class

It doesn't have CSS styles, and it was only in Vue. So it's totally unnecessary, remove it by the way.

Improve the Repo Topic Edit form

  • Simplify the code
  • Add a "Cancel" button
  • Align elements

Before:

image

After:

image

@wxiaoguang wxiaoguang force-pushed the fix-ui branch 2 times, most recently from 7cc9ec9 to f3acc93 Compare March 22, 2023 03:55
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Mar 22, 2023
@lunny lunny added this to the 1.20.0 milestone Mar 22, 2023
@silverwind
Copy link
Member

silverwind commented Mar 22, 2023

It's also done by $.fn.dropdown.settings.templates.label , cc: @silverwind

Nice, one step closer to removing FontAwesome. Do whe know which other parts of Fomantic are using icon fonts?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2023
@wxiaoguang
Copy link
Contributor Author

Do whe know which other parts of Fomantic are using icon fonts?

I have no idea at the moment. Maybe in the future, grepping the Fomantic source code would give some answers.

@silverwind
Copy link
Member

I imagine we need to remove the icon module when we do that, and I guess that module is imported in various other fomantic modules.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 25, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #23626 (25cc669) into main (f521e88) will increase coverage by 0.01%.
The diff coverage is 41.40%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #23626      +/-   ##
==========================================
+ Coverage   47.14%   47.16%   +0.01%     
==========================================
  Files        1149     1155       +6     
  Lines      151446   152396     +950     
==========================================
+ Hits        71397    71870     +473     
- Misses      71611    72055     +444     
- Partials     8438     8471      +33     
Impacted Files Coverage Δ
cmd/dump.go 0.66% <0.00%> (-0.01%) ⬇️
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.64% <0.00%> (-0.08%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
models/user/search.go 77.50% <0.00%> (-6.29%) ⬇️
modules/actions/workflows.go 0.00% <0.00%> (ø)
modules/context/context.go 64.54% <0.00%> (-3.53%) ⬇️
modules/doctor/storage.go 30.65% <0.00%> (-1.29%) ⬇️
modules/setting/git.go 45.45% <ø> (ø)
... and 37 more

... and 43 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lunny lunny merged commit 12fff36 into go-gitea:main Mar 26, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 26, 2023
@wxiaoguang wxiaoguang deleted the fix-ui branch March 26, 2023 11:35
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 27, 2023
* upstream/main: (23 commits)
  Fix project card preview select and template select (go-gitea#23684)
  [skip ci] Updated translations via Crowdin
  Add git dashes separator to some "log" and "diff" commands (go-gitea#23606)
  Add Simplified Chinese translate for oauth2-provider (go-gitea#23713)
  Fix incorrect `toggle` buttons (go-gitea#23676)
  Fine tune more downdrop settings, use SVG for labels, improve Repo Topic Edit form (go-gitea#23626)
  Allow new file and edit file preview if it has editable extension (go-gitea#23624)
  [skip ci] Updated translations via Crowdin
  Clean some legacy files and move some build files (go-gitea#23699)
  Remove row clicking from notification table (go-gitea#22695)
  Describe Gitea's purpose more accurately (go-gitea#23698)
  [skip ci] Updated translations via Crowdin
  ensure go/bin path exists when copying hugo bin into it (go-gitea#23692)
  Create commit status when event is `pull_request_sync` (go-gitea#23683)
  Add `deps-docs` command to makefile (go-gitea#23686)
  Fix incorrect package doc link (go-gitea#23679)
  Improve indices for `action` table (go-gitea#23532)
  Clarify that Gitea requires JavaScript (go-gitea#23677)
  Use data-tooltip-content for tippy tooltip (go-gitea#23649)
  Add aria attributes to interactive time tooltips. (go-gitea#23661)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants