-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine tune more downdrop settings, use SVG for labels, improve Repo Topic Edit form #23626
Conversation
7cc9ec9
to
f3acc93
Compare
Nice, one step closer to removing FontAwesome. Do whe know which other parts of Fomantic are using icon fonts? |
I have no idea at the moment. Maybe in the future, grepping the Fomantic source code would give some answers. |
I imagine we need to remove the |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23626 +/- ##
==========================================
+ Coverage 47.14% 47.16% +0.01%
==========================================
Files 1149 1155 +6
Lines 151446 152396 +950
==========================================
+ Hits 71397 71870 +473
- Misses 71611 72055 +444
- Partials 8438 8471 +33
... and 43 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* upstream/main: (23 commits) Fix project card preview select and template select (go-gitea#23684) [skip ci] Updated translations via Crowdin Add git dashes separator to some "log" and "diff" commands (go-gitea#23606) Add Simplified Chinese translate for oauth2-provider (go-gitea#23713) Fix incorrect `toggle` buttons (go-gitea#23676) Fine tune more downdrop settings, use SVG for labels, improve Repo Topic Edit form (go-gitea#23626) Allow new file and edit file preview if it has editable extension (go-gitea#23624) [skip ci] Updated translations via Crowdin Clean some legacy files and move some build files (go-gitea#23699) Remove row clicking from notification table (go-gitea#22695) Describe Gitea's purpose more accurately (go-gitea#23698) [skip ci] Updated translations via Crowdin ensure go/bin path exists when copying hugo bin into it (go-gitea#23692) Create commit status when event is `pull_request_sync` (go-gitea#23683) Add `deps-docs` command to makefile (go-gitea#23686) Fix incorrect package doc link (go-gitea#23679) Improve indices for `action` table (go-gitea#23532) Clarify that Gitea requires JavaScript (go-gitea#23677) Use data-tooltip-content for tippy tooltip (go-gitea#23649) Add aria attributes to interactive time tooltips. (go-gitea#23661) ...
Although it seems that some different purposes are mixed in this PR, however, they are all related, and can be tested together, so I put them together to save everyone's time.
Diff:
+79 −84
, everything becomes much better.Improve the dropdown settings.
Move all fomantic-init related code into our
fomantic.js
Fine-tune some dropdown global settings, see the comments.
Also help to fix the first problem in #23625 , cc: @yp05327
The "language" menu has been simplified, and it works with small-height window better.
Use SVG instead of
<i class="delete icon">
It's also done by
$.fn.dropdown.settings.templates.label
, cc: @silverwindRemove incorrect
tabable
CSS classIt doesn't have CSS styles, and it was only in Vue. So it's totally unnecessary, remove it by the way.
Improve the Repo Topic Edit form
Before:
After: