Add deps-docs command to makefile
#23686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored `deps-docs` out of `docs` because `go-gitea#23629` broke Gitpod's docs setup (which grepped to get the hugo install command).
yardenshoham
added
the
topic/build
zeripath
reviewed
Mar 24, 2023
Makefile
Outdated
| cd docs; make trans-copy clean build-offline; | ||
|
|
||
| .PHONY: deps-docs # TODO: find a way to install hugo without needing sudo permissions and add deps-docs to deps (the next block) | ||
| deps-docs: | ||
| @hash hugo > /dev/null 2>&1; if [ $$? -ne 0 ]; then \ | ||
| curl -sL https://github.com/gohugoio/hugo/releases/download/v$(HUGO_VERSION)/hugo_$(HUGO_VERSION)_Linux-64bit.tar.gz | tar zxf - -C /tmp && mv /tmp/hugo /usr/bin/hugo && chmod +x /usr/bin/hugo; \ |
There was a problem hiding this comment.
Do we really need to put hugo in /usr/bin? I wonder if there would be a better place to place this binary and call it?
For example couldn't it go in to ~/go/bin and have ~/go/bin be added on to the PATH?
There was a problem hiding this comment.
Changed to ~/go/bin
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Mar 24, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 24, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
ping lg-tm |
jolheiser
removed
the
reviewed/wait-merge
techknowlogick
added a commit
that referenced
this pull request
Mar 24, 2023
follow up of #23686 path does not exist during static pipeline, and fails out (example: https://drone.gitea.io/go-gitea/gitea/70587/1/5 )
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 27, 2023
* upstream/main: (23 commits) Fix project card preview select and template select (go-gitea#23684) [skip ci] Updated translations via Crowdin Add git dashes separator to some "log" and "diff" commands (go-gitea#23606) Add Simplified Chinese translate for oauth2-provider (go-gitea#23713) Fix incorrect `toggle` buttons (go-gitea#23676) Fine tune more downdrop settings, use SVG for labels, improve Repo Topic Edit form (go-gitea#23626) Allow new file and edit file preview if it has editable extension (go-gitea#23624) [skip ci] Updated translations via Crowdin Clean some legacy files and move some build files (go-gitea#23699) Remove row clicking from notification table (go-gitea#22695) Describe Gitea's purpose more accurately (go-gitea#23698) [skip ci] Updated translations via Crowdin ensure go/bin path exists when copying hugo bin into it (go-gitea#23692) Create commit status when event is `pull_request_sync` (go-gitea#23683) Add `deps-docs` command to makefile (go-gitea#23686) Fix incorrect package doc link (go-gitea#23679) Improve indices for `action` table (go-gitea#23532) Clarify that Gitea requires JavaScript (go-gitea#23677) Use data-tooltip-content for tippy tooltip (go-gitea#23649) Add aria attributes to interactive time tooltips. (go-gitea#23661) ...
delvh
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
deps-docsout ofdocsbecause #23629 broke Gitpod's docs setup (which grepped to get the hugo install command).Now
make depsreally installs everything to develop (includesdocs).