Use data-tooltip-content for tippy tooltip #23649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
refactor-tooltip-content
branch
from
c775700 to
1905b8b
Compare
# Conflicts: # templates/repo/sub_menu.tmpl
lunny
added
topic/ui
wxiaoguang
force-pushed
the
refactor-tooltip-content
branch
from
2083ad8 to
9c388a9
Compare
zeripath
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
I do wonder if we should add tippy to elements with title attributes - so that these get rendered in the same style.
I also wonder if we should just make this data-tooltip instead of data-tooltip-content because the content here seems unnecessary.
However, LGTM even without those.
GiteaBot
added
the
lgtm/need 1
No, sometimes, developers just want to use the native tooltip, give them the chance. Otherwise, the "title" attribute gets polluted. For example: #23574 (comment)
I would say it is necessary.
Thank you very much. |
lunny
approved these changes
Mar 24, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 27, 2023
* upstream/main: (23 commits) Fix project card preview select and template select (go-gitea#23684) [skip ci] Updated translations via Crowdin Add git dashes separator to some "log" and "diff" commands (go-gitea#23606) Add Simplified Chinese translate for oauth2-provider (go-gitea#23713) Fix incorrect `toggle` buttons (go-gitea#23676) Fine tune more downdrop settings, use SVG for labels, improve Repo Topic Edit form (go-gitea#23626) Allow new file and edit file preview if it has editable extension (go-gitea#23624) [skip ci] Updated translations via Crowdin Clean some legacy files and move some build files (go-gitea#23699) Remove row clicking from notification table (go-gitea#22695) Describe Gitea's purpose more accurately (go-gitea#23698) [skip ci] Updated translations via Crowdin ensure go/bin path exists when copying hugo bin into it (go-gitea#23692) Create commit status when event is `pull_request_sync` (go-gitea#23683) Add `deps-docs` command to makefile (go-gitea#23686) Fix incorrect package doc link (go-gitea#23679) Improve indices for `action` table (go-gitea#23532) Clarify that Gitea requires JavaScript (go-gitea#23677) Use data-tooltip-content for tippy tooltip (go-gitea#23649) Add aria attributes to interactive time tooltips. (go-gitea#23661) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow:
Major changes:
data-position, it's dead code since last Fomantic Tooltip -> Tippy Tooltip refactoringdata-contenttodata-reaction-contentdata-content:{{/* used by the form */}}