Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog to add missed changelog #32734

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Update changelog to add missed changelog #32734

merged 3 commits into from
Dec 6, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 6, 2024

No description provided.

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Dec 6, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 6, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 6, 2024
Zettat123
Zettat123 reviewed Dec 6, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@wxiaoguang
Copy link
Contributor

Should we still maintain the changelog in this repo?

These information has been duplicated in many places: commit history, github release, blog.

Maybe using github or gitea's wiki page to maintain the changelog is better and easier?

@lunny
Copy link
Member Author

lunny commented Dec 6, 2024

Should we still maintain the changelog in this repo?

These information has been duplicated in many places: commit history, github release, blog.

Maybe using github or gitea's wiki page to maintain the changelog is better and easier?

I think some people would like to view the changelogs in the same repository. Maybe we can just store changelogs in the main branch and will not store any release/* branch.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 6, 2024 •
edited
Loading

I think some people would like to view the changelogs in the same repository.

Who? The changelog is out-of-date for almost one year, nobody ever notices.

@silverwind
Copy link
Member

Changelog in the GitHub releases only may be enough. As I see it, it's duplicate information. Of course this presents a certain locking into the GitHub platform, but I assume GitHub releases could be migrated.

delvh
delvh approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine either way, regardless of our decision (keeping the CHANGELOG file only here, on all branches, only in the releases, …).

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 6, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 6, 2024
@yp05327
Copy link
Contributor

yp05327 commented Dec 6, 2024 •
edited
Loading

Maybe just give the link to the release page is enough.

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 6, 2024
@lunny lunny enabled auto-merge (squash) December 6, 2024 17:30
@lunny lunny merged commit 5a75160 into go-gitea:main Dec 6, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 6, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 6, 2024
@lunny lunny deleted the lunny/update_missing_changelog branch December 6, 2024 18:42
@lunny lunny removed this from the 1.24.0 milestone Dec 6, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 9, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
24b0634 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Fix repo home row-right grow (go-gitea#32763)
  Refactor issue list (go-gitea#32755)
  Fix compare page bug view as anonymous (go-gitea#32754)
  Split issue/pull view router function as multiple smaller functions (go-gitea#32749)
  fix: render job title as commit message (go-gitea#32748)
  Fix typescript errors in Vue files, fix regression in "Recent Commits" chart (go-gitea#32649)
  Refactor LabelEdit (go-gitea#32752)
  [skip ci] Updated translations via Crowdin
  fix(project): add title to project view page (go-gitea#32747)
  [skip ci] Updated translations via Crowdin
  Fix case of .tsbuildinfo in .gitignore (go-gitea#32737)
  Support "merge upstream branch" (Sync fork) (go-gitea#32741)
  Update changelog to add missed changelog (go-gitea#32734)
  GitHub like repo home page (go-gitea#32213)
  Refactor markdown render (go-gitea#32736)
  Make wiki pages visit fast (go-gitea#32732)
  Refactor markdown render (go-gitea#32728)
  Refactor RepoActionView.vue, add `::group::` support (go-gitea#32713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 left review comments

@delvh delvh delvh approved these changes

@yp05327 yp05327 yp05327 approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lunny @wxiaoguang @silverwind @yp05327 @appleboy @Zettat123 @delvh @GiteaBot